From: Lee Jones <lee.jones@linaro.org>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org, Stephen Warren <swarren@nvidia.com>,
Mark Brown <broonie@linaro.org>,
Michal Simek <michal.simek@xilinx.com>,
Andrew Bresticker <abrestic@chromium.org>,
Vince Hsu <vinceh@nvidia.com>
Subject: Re: [PATCH] mfd: as3722: make FUSE7_REG readable
Date: Wed, 19 Mar 2014 17:01:38 +0000 [thread overview]
Message-ID: <20140319170138.GK31687@lee--X1> (raw)
In-Reply-To: <5329C133.60900@wwwdotorg.org>
> >> From: Stephen Warren <swarren@nvidia.com>
> >>
> >> The FUSE7_REG register is not currently marked readable. This causes
> >> as3722_sd0_is_low_voltage() to emit an error during boot, and assume
> >> the range of the SD0 regulator:
> >>
> >> as3722-regulator as3722-regulator: Reg 0xa7 read failed: -5
> >>
> >> Fixes: d4807ad2c4c0 ("regmap: Check readable regs in _regmap_read")
> >> [exposed the bug, by checking for readability]
> >> Fixes: 762a8ee80897 ("regulator: as3722: detect SD0 low-voltage mode")
> >> [left out this register from the readable list]
> >> Cc: Mark Brown <broonie@linaro.org>
> >> Cc: Michal Simek <michal.simek@xilinx.com>
> >> Cc: Andrew Bresticker <abrestic@chromium.org>
> >> Cc: Vince Hsu <vinceh@nvidia.com>
> >> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> >> ---
> >> Note: I believe the regmap commit mentioned above is for 3.15, whereas
> >> the as3722 commit is in at least 3.14. So, this only needs to be applied
> >> for 3.15, but might make sense to go into earlier kernels, at your
> >> discretion.
> >
> > Applied to MFD -next (v3.15).
>
> I don't see this in next-20140319; did it get dropped somewhere, or was
> your branch not pushed out?
Ah, thanks for the reminder.
I moved the MFD tree from linaro.org to kernel.org, but failed to let
Stephen know. I'll do so now.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-03-19 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 16:50 [PATCH] mfd: as3722: make FUSE7_REG readable Stephen Warren
2014-03-05 1:55 ` Lee Jones
2014-03-19 16:09 ` Stephen Warren
2014-03-19 17:01 ` Lee Jones [this message]
2014-03-19 17:04 ` Lee Jones
2014-03-19 17:13 ` Stephen Warren
2014-03-19 21:45 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140319170138.GK31687@lee--X1 \
--to=lee.jones@linaro.org \
--cc=abrestic@chromium.org \
--cc=broonie@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=sameo@linux.intel.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
--cc=vinceh@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox