From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934102AbaCSRBr (ORCPT ); Wed, 19 Mar 2014 13:01:47 -0400 Received: from mail-we0-f173.google.com ([74.125.82.173]:41086 "EHLO mail-we0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933574AbaCSRBp (ORCPT ); Wed, 19 Mar 2014 13:01:45 -0400 Date: Wed, 19 Mar 2014 17:01:38 +0000 From: Lee Jones To: Stephen Warren Cc: Samuel Ortiz , linux-kernel@vger.kernel.org, Stephen Warren , Mark Brown , Michal Simek , Andrew Bresticker , Vince Hsu Subject: Re: [PATCH] mfd: as3722: make FUSE7_REG readable Message-ID: <20140319170138.GK31687@lee--X1> References: <1393951832-2638-1-git-send-email-swarren@wwwdotorg.org> <20140305015539.GK10579@lee--X1> <5329C133.60900@wwwdotorg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5329C133.60900@wwwdotorg.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > >> From: Stephen Warren > >> > >> The FUSE7_REG register is not currently marked readable. This causes > >> as3722_sd0_is_low_voltage() to emit an error during boot, and assume > >> the range of the SD0 regulator: > >> > >> as3722-regulator as3722-regulator: Reg 0xa7 read failed: -5 > >> > >> Fixes: d4807ad2c4c0 ("regmap: Check readable regs in _regmap_read") > >> [exposed the bug, by checking for readability] > >> Fixes: 762a8ee80897 ("regulator: as3722: detect SD0 low-voltage mode") > >> [left out this register from the readable list] > >> Cc: Mark Brown > >> Cc: Michal Simek > >> Cc: Andrew Bresticker > >> Cc: Vince Hsu > >> Signed-off-by: Stephen Warren > >> --- > >> Note: I believe the regmap commit mentioned above is for 3.15, whereas > >> the as3722 commit is in at least 3.14. So, this only needs to be applied > >> for 3.15, but might make sense to go into earlier kernels, at your > >> discretion. > > > > Applied to MFD -next (v3.15). > > I don't see this in next-20140319; did it get dropped somewhere, or was > your branch not pushed out? Ah, thanks for the reminder. I moved the MFD tree from linaro.org to kernel.org, but failed to let Stephen know. I'll do so now. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog