Re: [PATCH 2/3] regulator: bcm590xx: Remove **rdev from struct bcm590xx_reg

Matt Porter
2014-03-20T15:21:52Z

On Fri, Mar 14, 2014 at 09:59:07AM +0800, Axel Lin wrote:
> The **rdev of 'struct bcm590xx_reg' isn't used anywhere in the driver so
> remove it.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/regulator/bcm590xx-regulator.c | 10 ----------
> 1 file changed, 10 deletions(-)

Looks good, thanks for catching this.

Acked-by: Matt Porter <mporter@linaro.org>

>
> diff --git a/drivers/regulator/bcm590xx-regulator.c b/drivers/regulator/bcm590xx-regulator.c
> index d12d6d6..ab08ca7 100644
> --- a/drivers/regulator/bcm590xx-regulator.c
> +++ b/drivers/regulator/bcm590xx-regulator.c
> @@ -153,7 +153,6 @@ static struct bcm590xx_info bcm590xx_regs[] = {
> struct bcm590xx_reg {
> struct regulator_desc *desc;
> struct bcm590xx *mfd;
> - struct regulator_dev **rdev;
> struct bcm590xx_info **info;
> };
>
> @@ -334,13 +333,6 @@ static int bcm590xx_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> - pmu->rdev = devm_kzalloc(&pdev->dev, BCM590XX_NUM_REGS *
> - sizeof(struct regulator_dev *), GFP_KERNEL);
> - if (!pmu->rdev) {
> - dev_err(&pdev->dev, "Memory alloc fails for rdev\n");
> - return -ENOMEM;
> - }
> -
> info = bcm590xx_regs;
>
> for (i = 0; i < BCM590XX_NUM_REGS; i++, info++) {
> @@ -391,8 +383,6 @@ static int bcm590xx_probe(struct platform_device *pdev)
> pdev->name);
> return PTR_ERR(rdev);
> }
> -
> - pmu->rdev[i] = rdev;
> }
>
> return 0;
> --
> 1.8.1.2
>
>
>