public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	Samuel Ortiz <sameo@linux.intel.com>,
	Michael Brunner <michael.brunner@kontron.com>
Subject: Re: [PATCH] mfd: kempld-core: Fix potential hang-up during boot
Date: Thu, 20 Mar 2014 08:36:34 -0700	[thread overview]
Message-ID: <20140320153634.GB18690@roeck-us.net> (raw)
In-Reply-To: <20140320152812.GB8207@lee--X1>

On Thu, Mar 20, 2014 at 03:28:12PM +0000, Lee Jones wrote:
> > On PXT and COMe-cPC2 boards it is observed that the hardware
> > mutex is acquired but not being released during initialization.
> > This can result in a hang-up during boot if the driver is built
> > into the kernel.
> > 
> > Releasing the mutex twice if it was acquired fixes the problem.
> > Subsequent request/release cycles work as expected, so the fix is
> > only needed during initialization.
> > 
> > Reviewed-by: Michael Brunner <michael.brunner@kontron.com>
> > Tested-by: Michael Brunner <michael.brunner@kontron.com>
> > Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> > ---
> >  drivers/mfd/kempld-core.c |    7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> I was going to stop taking patches for this cycle, but as this looks
> like a bugfix I'll apply it, thanks.
> 

Hi Lee,

Great.

I should have added a note - the patch will also be needed in -stable;
the driver is used in both 3.12 and 3.13.

Thanks,
Guenter

  reply	other threads:[~2014-03-20 15:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-20 15:12 [PATCH] mfd: kempld-core: Fix potential hang-up during boot Guenter Roeck
2014-03-20 15:28 ` Lee Jones
2014-03-20 15:36   ` Guenter Roeck [this message]
2014-03-20 15:49     ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140320153634.GB18690@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.brunner@kontron.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox