public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Vince Weaver <vince@deater.net>
Cc: "Yan, Zheng" <zheng.z.yan@intel.com>,
	linux-kernel@vger.kernel.org, a.p.zijlstra@chello.nl,
	mingo@kernel.org, acme@infradead.org, eranian@google.com,
	andi@firstfloor.org
Subject: Re: [PATCH 4/4] perf/x86/uncore: modularize Intel uncore driver
Date: Thu, 20 Mar 2014 16:50:35 +0100	[thread overview]
Message-ID: <20140320155035.GJ22728@two.firstfloor.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1403201059250.8477@pianoman.cluster.toy>

> 
> I'm not necessarily against the idea, it's just it's tricky enough as it 
> is trying to help people with uncore pmu issues and now I will have to add 
> "make sure the relevant kernel module is loaded" to the list of things 
> that could be going wrong.

In theory the module could be always auto loaded (by adding a
exported pci_device_id to the driver). However for 99% of users it would
be wasted memory, as they never monitor anything.

One way to handle it would be just to add a request_module with
appropiate aliases to perf.

-Andi

  reply	other threads:[~2014-03-20 15:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-18  8:56 [PATCH 1/4] perf: allow building PMU driver as module Yan, Zheng
2014-03-18  8:56 ` [PATCH 2/4] hrtimer: export __hrtimer_start_range_ns Yan, Zheng
2014-03-19  8:47   ` Peter Zijlstra
2014-03-19  9:53     ` Thomas Gleixner
2014-03-19  9:58       ` Peter Zijlstra
2014-04-18 13:08   ` [tip:perf/core] hrtimer: Export __hrtimer_start_range_ns() tip-bot for Yan, Zheng
2014-03-18  8:56 ` [PATCH 3/4] perf/x86: export perf_assign_events Yan, Zheng
2014-04-18 13:08   ` [tip:perf/core] perf/x86: Export perf_assign_events() tip-bot for Yan, Zheng
2014-03-18  8:56 ` [PATCH 4/4] perf/x86/uncore: modularize Intel uncore driver Yan, Zheng
2014-03-19  8:49   ` Peter Zijlstra
2014-03-19 11:32     ` Ingo Molnar
2014-03-19 11:42       ` Peter Zijlstra
2014-03-19 11:53         ` Ingo Molnar
2014-03-19 12:44           ` Peter Zijlstra
2014-03-19 12:55             ` Ingo Molnar
2014-03-20 15:01   ` Vince Weaver
2014-03-20 15:50     ` Andi Kleen [this message]
2014-04-18 13:08 ` [tip:perf/core] perf: Allow building PMU drivers as modules tip-bot for Yan, Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140320155035.GJ22728@two.firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@infradead.org \
    --cc=eranian@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=vince@deater.net \
    --cc=zheng.z.yan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox