From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>, Minchan Kim <minchan@kernel.org>,
Nitin Gupta <ngupta@vflare.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: [PATCH] zram: include linux/err.h
Date: Thu, 20 Mar 2014 23:58:05 +0300 [thread overview]
Message-ID: <20140320205804.GA442@swordfish> (raw)
In-Reply-To: <20140319013946.GF13475@bbox>
On (03/19/14 10:39), Minchan Kim wrote:
> On Sat, Mar 15, 2014 at 10:40:08AM +0100, Arnd Bergmann wrote:
> > The zram driver uses the ERR_PTR macro defined in <linux/err.h>
> > and relies on this header to be included implicitly through
> > other headers, which is not (always) the case on the ARM architecture.
> >
> > Adding an explicit #include allows us to build the driver in
> > all configurations.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Regardless of resend fixing another part Sergey asked,
>
> Acked-by: Minchan Kim <minchan@kernel.org>
>
Andrew, could you please apply this one? I'll send a patch
to also include err.h in zram_drv shortly.
-ss
> Thanks!
>
>
> --
> Kind regards,
> Minchan Kim
>
prev parent reply other threads:[~2014-03-20 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 9:40 [PATCH] zram: include linux/err.h Arnd Bergmann
2014-03-15 14:18 ` Sergey Senozhatsky
2014-03-15 20:26 ` Arnd Bergmann
2014-03-18 18:35 ` Sergey Senozhatsky
[not found] ` <20140319013946.GF13475@bbox>
2014-03-20 20:58 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320205804.GA442@swordfish \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox