Re: [PATCH 3.10 76/85] Fix mountpoint reference leakage in linkat

Greg Kroah-Hartman
2014-03-21T00:36:56Z

On Thu, Mar 20, 2014 at 08:11:22PM -0400, Oleg Drokin wrote:
> Hello!
>
> On Mar 20, 2014, at 8:10 PM, Greg Kroah-Hartman wrote:
>
> > 3.10-stable review patch. If anyone has any objections, please let me know.
> >
> > ------------------
> >
> > From: Oleg Drokin <green@linuxhacker.ru>
> >
> > commit d22e6338db7f613dd4f6095c190682fcc519e4b7 upstream.
> >
> > Recent changes to retry on ESTALE in linkat
> > (commit 442e31ca5a49e398351b2954b51f578353fdf210)
> > introduced a mountpoint reference leak and a small memory
> > leak in case a filesystem link operation returns ESTALE
> > which is pretty normal for distributed filesystems like
> > lustre, nfs and so on.
> > Free old_path in such a case.
> >
> > [AV: there was another missing path_put() nearby - on the previous
> > goto retry]
>
> This comment loses sense in this version because there's no previous goto retry,
> though it might not be important due to it just being a port of an upstream commit, I guess.

True, but it's good to keep history around :)

thanks for the review.

greg k-h