From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966322AbaCUALv (ORCPT ); Thu, 20 Mar 2014 20:11:51 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37470 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966232AbaCUAJy (ORCPT ); Thu, 20 Mar 2014 20:09:54 -0400 From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Li Zefan , Tejun Heo Subject: [PATCH 3.4 17/35] cpuset: fix a race condition in __cpuset_node_allowed_softwall() Date: Thu, 20 Mar 2014 17:11:08 -0700 Message-Id: <20140321001054.739418258@linuxfoundation.org> X-Mailer: git-send-email 1.9.0 In-Reply-To: <20140321001054.038170009@linuxfoundation.org> References: <20140321001054.038170009@linuxfoundation.org> User-Agent: quilt/0.61-1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Li Zefan commit 99afb0fd5f05aac467ffa85c36778fec4396209b upstream. It's not safe to access task's cpuset after releasing task_lock(). Holding callback_mutex won't help. Signed-off-by: Li Zefan Signed-off-by: Tejun Heo Signed-off-by: Greg Kroah-Hartman --- kernel/cpuset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/kernel/cpuset.c +++ b/kernel/cpuset.c @@ -2338,9 +2338,9 @@ int __cpuset_node_allowed_softwall(int n task_lock(current); cs = nearest_hardwall_ancestor(task_cs(current)); + allowed = node_isset(node, cs->mems_allowed); task_unlock(current); - allowed = node_isset(node, cs->mems_allowed); mutex_unlock(&callback_mutex); return allowed; }