From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: broonie@kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, rob@landley.net, sameo@linux.intel.com,
lgirdwood@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] regulator: arizona-micsupp: Add processing of init_data from device tree
Date: Fri, 21 Mar 2014 10:28:25 +0000 [thread overview]
Message-ID: <20140321102825.GE15213@lee--X1> (raw)
In-Reply-To: <1395224338-3709-6-git-send-email-ckeepax@opensource.wolfsonmicro.com>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
> Documentation/devicetree/bindings/mfd/arizona.txt | 6 ++-
> drivers/regulator/arizona-micsupp.c | 50 +++++++++++++++++++++
For the sake of simplicity would you be kind enough to submit MFD
documentation separate from sub-device code please?
> 2 files changed, 54 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/arizona.txt b/Documentation/devicetree/bindings/mfd/arizona.txt
> index 9d54c70..9c685b2 100644
> --- a/Documentation/devicetree/bindings/mfd/arizona.txt
> +++ b/Documentation/devicetree/bindings/mfd/arizona.txt
> @@ -44,9 +44,11 @@ Optional properties:
>
> - ldo1 : Initial data for the LDO1 regulator, as covered in
> Documentation/devicetree/bindings/regulator/regulator.txt
> + - micvdd : Initial data for the MICVDD regulator, as covered in
> + Documentation/devicetree/bindings/regulator/regulator.txt
>
> - - DCVDD-supply : Power supply, only needs to be specified if DCVDD is being
> - externally supplied. As covered in
> + - DCVDD-supply, MICVDD-supply : Power supplies, only need to be specified if
> + they are being externally supplied. As covered in
> Documentation/devicetree/bindings/regulator/regulator.txt
Changes looks good to me, but I'd still like Mark's Ack at a minimum,
ideally someone from DT too.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-03-21 10:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-19 10:18 [PATCH 0/5] Arizona regulator updates v3 Charles Keepax
2014-03-19 10:18 ` [PATCH 1/5] arizona: Correct small errors in the DT binding documentation Charles Keepax
2014-03-21 10:54 ` Lee Jones
2014-03-19 10:18 ` [PATCH 2/5] mfd: arizona: Fix and factor out read of device tree GPIOs Charles Keepax
2014-03-21 10:52 ` Lee Jones
2014-03-21 15:44 ` Charles Keepax
2014-03-24 8:44 ` Lee Jones
2014-03-19 10:18 ` [PATCH 3/5] regulator: arizona-ldo1: Move setup processing from arizona-core Charles Keepax
2014-03-21 10:40 ` Lee Jones
2014-03-19 10:18 ` [PATCH 4/5] regulator: arizona-ldo1: Add processing of init_data from device tree Charles Keepax
2014-03-21 10:34 ` Lee Jones
2014-03-21 15:45 ` Charles Keepax
2014-03-19 10:18 ` [PATCH 5/5] regulator: arizona-micsupp: " Charles Keepax
2014-03-21 10:28 ` Lee Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-03-18 17:22 [PATCH 0/5] Arizona regulator updates v2 Charles Keepax
2014-03-18 17:22 ` [PATCH 5/5] regulator: arizona-micsupp: Add processing of init_data from device tree Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321102825.GE15213@lee--X1 \
--to=lee.jones@linaro.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox