From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760519AbaCULOJ (ORCPT ); Fri, 21 Mar 2014 07:14:09 -0400 Received: from top.free-electrons.com ([176.31.233.9]:55516 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1760236AbaCULOH (ORCPT ); Fri, 21 Mar 2014 07:14:07 -0400 Date: Fri, 21 Mar 2014 12:14:04 +0100 From: Alexandre Belloni To: Rob Herring Cc: Jean-Christophe Plagniol-Villard , Nicolas Ferre , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] Documentation: dt: list all compatible strings for at91 Message-ID: <20140321111403.GA6443@piout.net> References: <1395224808-10133-1-git-send-email-alexandre.belloni@free-electrons.com> <20140320162100.GU12021@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140320162100.GU12021@piout.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 20/03/2014 at 17:21:00 +0100, Alexandre Belloni wrote : > Hi Rob, > > On 19/03/2014 at 11:14:43 -0500, Rob Herring wrote : > > On Wed, Mar 19, 2014 at 5:26 AM, Alexandre Belloni > > wrote: > > > Avoids getting the newly introduced warning: > > > WARNING: DT compatible string "atmel,at91sam9g45-adc" appears un-documented -- check ./Documentation/devicetree/bindings/ > > > + compatible = "atmel,at91sam9g45-adc"; > > > > > > Introduced by: > > > bff5da433525 checkpatch: add DT compatible string documentation checks > > > > We should fix checkpatch instead. There are some fixes in progress, > > but I don't think it covers this issue. I'm puzzled by this one as I > > thought I checked for this case. > > > > Will someone take care of it ? I'm not sure how you want to handle that > as is replacing different values depending on the context. Also, > while for atmel and freescale, it is replacing the full chip name, that > is not the case for nvidia... > Also, I found that naughty one: WARNING: DT compatible string vendor "fixed-clock" appears un-documented -- check ./Documentation/devicetree/bindings/vendor-prefixes.txt and WARNING: DT compatible string vendor "fixed-factor-clock" appears un-documented -- check ./Documentation/devicetree/bindings/vendor-prefixes.txt -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com