From: Jean Delvare <jdelvare@suse.de>
To: Andi Kleen <andi@firstfloor.org>
Cc: Joe Perches <joe@perches.com>, Andy Whitcroft <apw@canonical.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: checkpatch on Kconfig files
Date: Fri, 21 Mar 2014 14:36:42 +0100 [thread overview]
Message-ID: <20140321143642.404183e5@endymion.delvare> (raw)
In-Reply-To: <20140321132121.GL22728@two.firstfloor.org>
Hi Andi,
On Fri, 21 Mar 2014 14:21:21 +0100, Andi Kleen wrote:
> > I believe that was Andi Kleen's pet peeve,
> > so I'll punt it back to him.
>
> This was always in checkpatch. If you touch/move some existing
> code it blames you for the issues that were already there.
>
> Not specific to this check.
Actually it is. I was not moving the Kconfig entry, and I was not
touching its help text either. Here checkpatch complained about
something which was in the context of the patch, not in added or
modified lines. I am not aware of any other check doing that,
thankfully.
If I obeyed to checkpatch and "fixed" the help text to make it happy,
the reviewer would have (rightfully) rejected my patch as mixing
unrelated changes together.
> If you disagree with the warnings just ignore them.
This is a false positive, and checkpatch explicitly asks for these to
be reported. Which is what I'm doing. Better tools make future
contributions better and easier.
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2014-03-21 13:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 8:42 checkpatch on Kconfig files Jean Delvare
2014-03-21 8:57 ` Joe Perches
2014-03-21 13:21 ` Andi Kleen
2014-03-21 13:36 ` Jean Delvare [this message]
2014-03-21 15:18 ` Joe Perches
2014-03-21 16:11 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321143642.404183e5@endymion.delvare \
--to=jdelvare@suse.de \
--cc=andi@firstfloor.org \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox