From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Josh Hunt <joshhunt00@gmail.com>
Cc: "Banerjee, Debabrata" <dbanerje@akamai.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Kay Sievers <kay.sievers@vrfy.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jeff Mahoney <jeffm@suse.com>,
"dbavatar@gmail.com" <dbavatar@gmail.com>,
"Hunt, Joshua" <johunt@akamai.com>,
stable <stable@vger.kernel.org>
Subject: Re: [PATCH] printk: Fix discarding of records
Date: Fri, 21 Mar 2014 08:33:08 -0700 [thread overview]
Message-ID: <20140321153308.GA31920@kroah.com> (raw)
In-Reply-To: <CAKA=qzYGmfCyon-UcsQxMUwuP+ppmEHgrf4iKBOz+16_HaNTDA@mail.gmail.com>
On Fri, Mar 21, 2014 at 10:18:13AM -0500, Josh Hunt wrote:
> On Sun, Feb 16, 2014 at 8:38 PM, Banerjee, Debabrata
> <dbanerje@akamai.com> wrote:
> > On 2/16/14, 7:41 PM, "Linus Torvalds" <torvalds@linux-foundation.org>
> > wrote:
> >
> >>On Sun, Feb 16, 2014 at 4:19 PM, Banerjee, Debabrata
> >><dbanerje@akamai.com> wrote:
> >>>
> >>> No that can't be right, the prev value after every loop is the
> >>>msg->flags
> >>> from the *last* line in the list, which has no relation to the *first*,
> >>>so
> >>> reusing it for the top of the next loop is nonsense.
> >>
> >>Please, Debabrata, humor me, and just try the patch.
> >>
> >>And try reading the source code. Because your statement is BS.
> > ...
> >>No, I haven't tested my patch, and maybe it's broken for some subtle
> >>reason I'm missing too.
> >
> > Yes my explanation was wrong, your patch works for me. I assumed printing
> > the prefix was desired, but if not, great.
>
> The resulting patch from this discussion:
>
> commit e4178d809fdaee32a56833fff1f5056c99e90a1a
> Author: Linus Torvalds <torvalds@linux-foundation.org>
> Date: Mon Feb 17 12:24:45 2014 -0800
>
> printk: fix syslog() overflowing user buffer
>
> has not made it into stable yet. Can we add it to the stable queue?
> I'm not sure if it needs more bake time, etc.
I'll queue it up for the next round of stable releases after this one,
thanks for pointing it out.
greg k-h
next prev parent reply other threads:[~2014-03-21 15:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 4:42 [PATCH] printk: Fix discarding of records Debabrata Banerjee
2014-02-16 19:28 ` Linus Torvalds
2014-02-16 20:47 ` Greg Kroah-Hartman
2014-02-16 23:05 ` Kay Sievers
2014-02-16 23:23 ` Banerjee, Debabrata
2014-02-16 23:59 ` Linus Torvalds
2014-02-17 0:19 ` Banerjee, Debabrata
2014-02-17 0:41 ` Linus Torvalds
2014-02-17 0:50 ` Kay Sievers
2014-02-17 0:57 ` Linus Torvalds
2014-02-17 1:19 ` Kay Sievers
2014-02-17 1:41 ` Kay Sievers
2014-02-17 2:38 ` Banerjee, Debabrata
2014-03-21 15:18 ` Josh Hunt
2014-03-21 15:33 ` Greg Kroah-Hartman [this message]
2014-02-16 23:24 ` [PATCH v2] " Debabrata Banerjee
2014-02-17 0:42 ` [PATCH v3] " Debabrata Banerjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140321153308.GA31920@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dbanerje@akamai.com \
--cc=dbavatar@gmail.com \
--cc=jeffm@suse.com \
--cc=johunt@akamai.com \
--cc=joshhunt00@gmail.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox