From: tytso@mit.edu
To: Andrew Morton <akpm@linux-foundation.org>,
Fabian Frederick <fabf@skynet.be>,
linux-kernel <linux-kernel@vger.kernel.org>,
reiserfs-devel@vger.kernel.org
Subject: Re: [RFC 1/1] fs/reiserfs/journal.c: Remove obsolete __GFP_NOFAIL
Date: Sat, 22 Mar 2014 13:32:07 -0400 [thread overview]
Message-ID: <20140322173207.GC23583@thunk.org> (raw)
In-Reply-To: <20140322172606.GB23583@thunk.org>
On Sat, Mar 22, 2014 at 01:26:06PM -0400, tytso@MIT.EDU wrote:
> > Well. Converting an existing retry-for-ever caller to GFP_NOFAIL is
> > good. Adding new retry-for-ever code is not good.
Oh, and BTW --- now that checkpatch.pl now flags an warning whenever
GFP_NOFAIL is used, because it is deprecated, patches that convert a
loop to use GFP_NOFAIL will get flagged with checkpatch, and this will
also incentivize people writing new code and who can't find any other
way to deal with an allocation failure to simply open code the loop...
- Ted
next prev parent reply other threads:[~2014-03-22 17:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 16:18 [RFC 1/1] fs/reiserfs/journal.c: Remove obsolete __GFP_NOFAIL Fabian Frederick
2014-03-21 20:00 ` Andrew Morton
2014-03-21 23:21 ` Fabian Frederick
2014-03-21 23:27 ` Andrew Morton
2014-03-22 17:03 ` tytso
2014-03-22 17:15 ` Andrew Morton
2014-03-22 17:26 ` tytso
2014-03-22 17:32 ` tytso [this message]
2014-03-22 17:55 ` Andrew Morton
2014-03-22 18:12 ` tytso
2014-03-22 18:56 ` Joe Perches
2014-03-26 1:07 ` David Rientjes
2014-03-22 19:24 ` Dave Jones
2014-03-26 1:06 ` David Rientjes
2014-03-26 6:19 ` tytso
2014-03-26 6:32 ` Andrew Morton
2014-03-26 13:29 ` tytso
2014-03-27 4:38 ` David Rientjes
2014-03-22 21:13 ` Fabian Frederick
2014-03-24 14:00 ` One Thousand Gnomes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140322173207.GC23583@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox