Re: [RFC 1/1] fs/reiserfs/journal.c: Remove obsolete __GFP_NOFAIL

Fabian Frederick
2014-03-22T21:12:38Z

On Sat, 22 Mar 2014 10:55:24 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Sat, 22 Mar 2014 13:32:07 -0400 tytso@mit.edu wrote:
>
> > On Sat, Mar 22, 2014 at 01:26:06PM -0400, tytso@MIT.EDU wrote:
> > > > Well. Converting an existing retry-for-ever caller to GFP_NOFAIL is
> > > > good. Adding new retry-for-ever code is not good.
> >
> > Oh, and BTW --- now that checkpatch.pl now flags an warning whenever
> > GFP_NOFAIL is used
>
> I don't know what the basis for this NOFAIL-is-going-away theory could
> have been. What's the point in taking a centrally implemented piece of
> logic and splattering its implementation out to tens of different
> callsites?
>
> Obviously I was asleep when I merged that checkpatch change.

Exactly where confusion came from, thanks !

Fabian