From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752175AbaCWTj5 (ORCPT ); Sun, 23 Mar 2014 15:39:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36713 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751968AbaCWTjC (ORCPT ); Sun, 23 Mar 2014 15:39:02 -0400 Date: Sun, 23 Mar 2014 20:38:04 +0100 From: Oleg Nesterov To: Andrew Morton Cc: Al Viro , David Woodhouse , Richard Weinberger , Tejun Heo , linux-kernel@vger.kernel.org Subject: [PATCH 08/11] signals: kill the obsolete sigdelset() and recalc_sigpending() in allow_signal() Message-ID: <20140323193804.GA10517@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140323193730.GA10464@redhat.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org allow_signal() does sigdelset(current->blocked) due to historic reason, previously it could be called by a daemonize()'ed kthread, and daemonize() played with current->blocked. Now that daemonize() has gone away we can remove sigdelset() and recalc_sigpending(). If a user really wants to unblock a signal, it must use sigprocmask() or set_current_block() explicitely. Signed-off-by: Oleg Nesterov --- kernel/signal.c | 5 +---- 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index a2b8c1b..30bfe53 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -3069,16 +3069,13 @@ COMPAT_SYSCALL_DEFINE4(rt_tgsigqueueinfo, */ void allow_signal(int sig) { - spin_lock_irq(¤t->sighand->siglock); - /* This is only needed for daemonize()'ed kthreads */ - sigdelset(¤t->blocked, sig); /* * Kernel threads handle their own signals. Let the signal code * know it'll be handled, so that they don't get converted to * SIGKILL or just silently dropped. */ + spin_lock_irq(¤t->sighand->siglock); current->sighand->action[(sig)-1].sa.sa_handler = (void __user *)2; - recalc_sigpending(); spin_unlock_irq(¤t->sighand->siglock); } EXPORT_SYMBOL(allow_signal); -- 1.5.5.1