From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753366AbaCXNhF (ORCPT ); Mon, 24 Mar 2014 09:37:05 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:63873 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243AbaCXNgt (ORCPT ); Mon, 24 Mar 2014 09:36:49 -0400 Date: Mon, 24 Mar 2014 13:36:42 +0000 From: Lee Jones To: Gabriel FERNANDEZ Cc: Dmitry Torokhov , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Rob Landley , Russell King , Grant Likely , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, kernel@stlinux.com, Giuseppe Condorelli Subject: Re: [PATCH v2 1/5] drivers: input: keyboard: st-keyscan: add keyscan driver Message-ID: <20140324133642.GB21665@lee--X1> References: <1395154806-2810-1-git-send-email-gabriel.fernandez@st.com> <1395154806-2810-2-git-send-email-gabriel.fernandez@st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1395154806-2810-2-git-send-email-gabriel.fernandez@st.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > This patch adds ST Keyscan driver to use the keypad hw a subset > of ST boards provide. Specific board setup will be put in the > given dt. > > Signed-off-by: Gabriel Fernandez > Signed-off-by: Giuseppe Condorelli > --- > .../devicetree/bindings/input/st-keyscan.txt | 60 +++++ > drivers/input/keyboard/Kconfig | 12 + > drivers/input/keyboard/Makefile | 1 + > drivers/input/keyboard/st-keyscan.c | 260 +++++++++++++++++++++ > 4 files changed, 333 insertions(+) > create mode 100644 Documentation/devicetree/bindings/input/st-keyscan.txt > create mode 100644 drivers/input/keyboard/st-keyscan.c FWIW: This looks good to me now: Acked-by: Lee Jones -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog