From: Joerg Roedel <joro@8bytes.org>
To: suravee.suthikulpanit@amd.com
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
kim.naru@amd.com, jay.cornwall@amd.com
Subject: Re: [PATCH V2] iommu/amd: Fix logic to determine and checking max PASID
Date: Mon, 24 Mar 2014 16:48:06 +0100 [thread overview]
Message-ID: <20140324154806.GB2775@8bytes.org> (raw)
In-Reply-To: <1394067258-5968-1-git-send-email-suravee.suthikulpanit@amd.com>
On Wed, Mar 05, 2014 at 06:54:18PM -0600, suravee.suthikulpanit@amd.com wrote:
> From: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
>
> In reality, the spec can only support 16-bit PASID since
> INVALIDATE_IOTLB_PAGES and COMPLETE_PPR_REQUEST commands only allow 16-bit
> PASID. So, we updated the PASID_MASK accordingly and invoke BUG_ON
> if the hardware is reporting PASmax more than 16-bit.
>
> Besides, max PASID is defined as ((2^(PASmax+1)) - 1). The current does not
> determine this correctly.
>
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> Tested-by: Jay Cornwall <Jay.Cornwall@amd.com>
Applied, thanks.
Btw, is there any publicly available driver/way/whatever for me to test the
AMD IOMMUv2 code paths?
Joerg
next prev parent reply other threads:[~2014-03-24 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 0:54 [PATCH V2] iommu/amd: Fix logic to determine and checking max PASID suravee.suthikulpanit
2014-03-21 19:07 ` Suravee Suthikulpanit
2014-03-24 15:48 ` Joerg Roedel [this message]
2014-03-24 19:33 ` Cornwall, Jay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140324154806.GB2775@8bytes.org \
--to=joro@8bytes.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jay.cornwall@amd.com \
--cc=kim.naru@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox