From: "Eric Bénard" <eric@eukrea.com>
To: CHAUMETTE Hubert <hchaumette@adeneo-embedded.com>
Cc: linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
shawn guo <shawn.guo@linaro.org>,
linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] ARM: i.MX6: update KSZ9031 phy fixup
Date: Mon, 24 Mar 2014 16:41:41 +0100 [thread overview]
Message-ID: <20140324164141.51b85f8c@e6520eb> (raw)
In-Reply-To: <1762157698.5689069.1395675049240.JavaMail.zimbra@adeneo-embedded.com>
Hi Hubert,
Le Mon, 24 Mar 2014 16:30:49 +0100 (CET),
CHAUMETTE Hubert <hchaumette@adeneo-embedded.com> a écrit :
> > From: "Eric Bénard" <eric@eukrea.com>
> > that's board specific (the needed delay depends on the routing delay on
> > the PCB), so this should not go in a generic file.
> >
> > Eric
> >
>
> I admit it may need to be in a separate function, but this file already contains
> board-specific fixups (for imx6q sabrelite, Data Modul eDM-QMX6).
>
true but that's not a reason to add more ;-)
> Anyway, do you have any suggestion for the location I should put it ?
>
no idea at the moment, I simply used your patch to bring this issue on
the ML as we recently needed to patch the default values for testing
mainline kernel on a custom boards.
Eric
next prev parent reply other threads:[~2014-03-24 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 17:08 [PATCH] ARM: i.MX6: update KSZ9031 phy fixup Hubert Chaumette
2014-03-21 21:23 ` Eric Bénard
2014-03-24 15:30 ` CHAUMETTE Hubert
2014-03-24 15:41 ` Eric Bénard [this message]
2014-04-02 13:14 ` Shawn Guo
2014-04-02 13:38 ` Eric Bénard
2014-04-02 14:14 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140324164141.51b85f8c@e6520eb \
--to=eric@eukrea.com \
--cc=hchaumette@adeneo-embedded.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox