From: Greg KH <gregkh@linuxfoundation.org>
To: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls
Date: Tue, 25 Mar 2014 11:51:45 -0700 [thread overview]
Message-ID: <20140325185145.GA4509@kroah.com> (raw)
In-Reply-To: <20140325183618.GD17209@kaos.lebenslange-mailadresse.de>
On Tue, Mar 25, 2014 at 06:36:18PM +0000, Wilfried Klaebe wrote:
> Am Tue, Mar 25, 2014 at 11:17:49AM -0700 schrieb Greg KH:
> > On Tue, Mar 25, 2014 at 05:59:39PM +0000, Wilfried Klaebe wrote:
> > > staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls
> > >
> > > It looks like someone did a search-and-replace on that driver, putting
> > > spaces before "=" characters, without checking this is OK everywhere.
> > > Also, in some places, there's memcpm()s/strncmp()s checking for some
> > > different length than the fixed string argument.
> > >
> > > These things result in code not working as intended. Fix that.
> >
> > What code is parsing string output from the kernel?
>
> I know about some userspace apps, for example a MiraCast Sink
> implementation for the Raspberry Pi, called piracast.
>
> This patch though is about the rtl8188eu driver parsing strings
> handed to it via "iwpriv wlanX p2p_set name=value". Which breaks,
> because the driver checks for "name =" instead of "name=" in several
> cases.
That's horrid on so many levels...
next prev parent reply other threads:[~2014-03-25 18:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 17:59 [PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls Wilfried Klaebe
2014-03-25 18:17 ` Greg KH
2014-03-25 18:36 ` Wilfried Klaebe
2014-03-25 18:51 ` Greg KH [this message]
2014-03-25 19:04 ` Wilfried Klaebe
2014-03-25 22:40 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140325185145.GA4509@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox