From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753725AbaCYWi7 (ORCPT ); Tue, 25 Mar 2014 18:38:59 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:48186 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476AbaCYWi6 (ORCPT ); Tue, 25 Mar 2014 18:38:58 -0400 Date: Tue, 25 Mar 2014 15:40:38 -0700 From: Greg KH To: Larry.Finger@lwfinger.net, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls Message-ID: <20140325224038.GB28590@kroah.com> References: <20140325175939.GC17209@kaos.lebenslange-mailadresse.de> <20140325181749.GE3233@kroah.com> <20140325183618.GD17209@kaos.lebenslange-mailadresse.de> <20140325185145.GA4509@kroah.com> <20140325190434.GE17209@kaos.lebenslange-mailadresse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140325190434.GE17209@kaos.lebenslange-mailadresse.de> User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 25, 2014 at 07:04:34PM +0000, Wilfried Klaebe wrote: > Am Tue, Mar 25, 2014 at 11:51:45AM -0700 schrieb Greg KH: > > On Tue, Mar 25, 2014 at 06:36:18PM +0000, Wilfried Klaebe wrote: > > > Am Tue, Mar 25, 2014 at 11:17:49AM -0700 schrieb Greg KH: > > > > On Tue, Mar 25, 2014 at 05:59:39PM +0000, Wilfried Klaebe wrote: > > > > > staging: rtl8188eu: remove spaces, correct counts to unbreak P2P ioctls > > > > > > > > > > It looks like someone did a search-and-replace on that driver, putting > > > > > spaces before "=" characters, without checking this is OK everywhere. > > > > > Also, in some places, there's memcpm()s/strncmp()s checking for some > > > > > different length than the fixed string argument. > > > > > > > > > > These things result in code not working as intended. Fix that. > > > > > > > > What code is parsing string output from the kernel? > > > > > > I know about some userspace apps, for example a MiraCast Sink > > > implementation for the Raspberry Pi, called piracast. > > > > > > This patch though is about the rtl8188eu driver parsing strings > > > handed to it via "iwpriv wlanX p2p_set name=value". Which breaks, > > > because the driver checks for "name =" instead of "name=" in several > > > cases. > > > > That's horrid on so many levels... > > The real WTF is: why doesn't this driver use the stuff already there for > Wi-Fi Direct (aka P2P Wifi)? > > But well, for now I just wanted to contribute my fixes to this obvious > breakage; making a sensible driver out of that mess is a longer-term > project. No worries, just complaining, it's not your fault. I'll queue it up after 3.15-rc1 is out, thanks. greg k-h