From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] workqueue: add __WQ_FREEZING and remove POOL_FREEZING
Date: Thu, 27 Mar 2014 10:48:54 -0400 [thread overview]
Message-ID: <20140327144854.GA18503@htj.dyndns.org> (raw)
In-Reply-To: <533414C7.1050607@cn.fujitsu.com>
On Thu, Mar 27, 2014 at 08:08:39PM +0800, Lai Jiangshan wrote:
> On 03/25/2014 05:56 PM, Lai Jiangshan wrote:
> > freezing is nothing related to pools, but POOL_FREEZING adds a connection,
> > and causes freeze_workqueues_begin() and thaw_workqueues() complicated.
> >
> > Since freezing is workqueue instance attribute, so we introduce __WQ_FREEZING
> > to wq->flags instead and remove POOL_FREEZING.
> >
> > we set __WQ_FREEZING only when freezable(to simplify pwq_adjust_max_active()),
> > make freeze_workqueues_begin() and thaw_workqueues() fast skip non-freezable wq.
> >
> > Changed from previous patches(requested by tj):
> > 1) added the WARN_ON_ONCE() back
> > 2) merged the two patches as one
>
> Ping.
>
> Hi, Tejun
>
> You had reviewed this patch several rounds.
> I had applied all your requests(the last two is listed above) in your comments.
>
> I'm deeply sorry for responding so late.
No worries but I think it's a bit too late in the devel cycle to apply
it to for-3.15. Let's do it in the next cycle. Can you please ping
me when v3.16-rc1 drops?
Thanks.
--
tejun
next prev parent reply other threads:[~2014-03-27 14:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-04 2:05 [PATCH 1/7] workqueue: add __WQ_FREEZING and remove POOL_FREEZING Lai Jiangshan
2013-04-04 2:05 ` [PATCH 2/7] workqueue: set __WQ_FREEZING only when freezable Lai Jiangshan
2013-04-04 2:05 ` [PATCH 3/7] workqueue: rename rebind_workers() to associate_cpu_pool() Lai Jiangshan
2013-04-04 14:15 ` Tejun Heo
2013-04-04 2:05 ` [PATCH 4/7] workqueue: simplify workqueue_cpu_up_callback(CPU_ONLINE) Lai Jiangshan
2013-04-04 2:05 ` [PATCH 5/7] workqueue, use default pwq when fail to allocate node pwd Lai Jiangshan
2013-04-04 14:34 ` Tejun Heo
2013-04-04 2:05 ` [PATCH 6/7] workqueue: node-awared allocation for unbound pool Lai Jiangshan
2013-04-04 14:38 ` Tejun Heo
2013-04-04 2:05 ` [PATCH 7/7] workqueue: avoid false negative WARN_ON() Lai Jiangshan
2013-04-04 14:55 ` [PATCH] workqueue: avoid false negative WARN_ON() in destroy_workqueue() Tejun Heo
2013-04-05 7:39 ` Lai Jiangshan
2013-04-04 14:12 ` [PATCH 1/7] workqueue: add __WQ_FREEZING and remove POOL_FREEZING Tejun Heo
2013-04-20 16:12 ` Lai Jiangshan
2013-04-21 1:29 ` Tejun Heo
2014-03-25 9:56 ` [PATCH] " Lai Jiangshan
2014-03-27 12:08 ` Lai Jiangshan
2014-03-27 14:48 ` Tejun Heo [this message]
2014-04-16 19:51 ` Tejun Heo
2014-04-16 23:58 ` Lai Jiangshan
2014-04-17 15:29 ` Tejun Heo
2014-04-16 20:50 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140327144854.GA18503@htj.dyndns.org \
--to=tj@kernel.org \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox