From: Wolfram Sang <wsa@the-dreams.de>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kevin.z.m.zh@gmail.com,
sunny@allwinnertech.com, shuge@allwinnertech.com,
zhuzhenhua@allwinnertech.com, linux@arm.linux.org.uk
Subject: Re: [PATCH] i2c: mv64xxx: Fix reset controller handling
Date: Fri, 28 Mar 2014 08:49:00 +0100 [thread overview]
Message-ID: <20140328074900.GC2708@katana> (raw)
In-Reply-To: <1394449930-29696-1-git-send-email-maxime.ripard@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]
On Mon, Mar 10, 2014 at 12:12:10PM +0100, Maxime Ripard wrote:
> The reset framework recently gained optional stubs when CONFIG_RESET_CONTROLLER
> is not selected. It also introduced a function reset_get_optional, that is also
> dummy-defined whenever the framework isn't enabled, for drivers that needs an
> optional reset controller.
>
> Switch to this function, since the mv64xxx driver is in this case. This also
> fixes a compilation breakage whenever the reset framework wasn't selected:
>
> drivers/i2c/busses/i2c-mv64xxx.c:771:2: error: implicit declaration of function 'devm_reset_control_get'
>
> While we're at it, remove the redundant test on dev.of_node surrounding the
> calls to reset framework functions, since it will either be a valid pointer, an
> error pointer in the case where we called reset_get_optional without an of_node
> pointer or if it failed, or NULL if we're not loaded through DT.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Applied to for-next, thanks!
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-28 7:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 11:12 [PATCH] i2c: mv64xxx: Fix reset controller handling Maxime Ripard
2014-03-28 7:49 ` Wolfram Sang [this message]
2014-03-28 8:24 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328074900.GC2708@katana \
--to=wsa@the-dreams.de \
--cc=kevin.z.m.zh@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=maxime.ripard@free-electrons.com \
--cc=shuge@allwinnertech.com \
--cc=sunny@allwinnertech.com \
--cc=zhuzhenhua@allwinnertech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox