From: Lee Jones <lee.jones@linaro.org>
To: Roger <rogerable@realtek.com>
Cc: Oliver Neukum <oneukum@suse.de>,
Samuel Ortiz <sameo@linux.intel.com>,
Chris Ball <chris@printf.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Maxim Levitsky <maximlevitsky@gmail.com>,
Alex Dubov <oakad@yahoo.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org,
driverdev-devel@linuxdriverproject.org, wei_wang@realsil.com.cn,
micky_ching@realsil.com.cn
Subject: Re: [PATCH v5 1/3] mfd: Add realtek USB card reader driver
Date: Fri, 28 Mar 2014 07:59:42 +0000 [thread overview]
Message-ID: <20140328075942.GD17779@lee--X1> (raw)
In-Reply-To: <5334ED70.6050309@realtek.com>
[...]
> >>+static int rtsx_usb_suspend(struct usb_interface *intf, pm_message_t message)
> >>+{
> >>+ struct rtsx_ucr *ucr =
> >>+ (struct rtsx_ucr *)usb_get_intfdata(intf);
> >>+
> >>+ dev_dbg(&intf->dev, "%s called with pm message 0x%04u\n",
> >>+ __func__, message.event);
> >>+
> >>+ mutex_lock(&ucr->dev_mutex);
> >>+ rtsx_usb_turn_off_led(ucr);
> >
> >When is this turned on again?
> >
>
> The LED is not in a permanent cut-off state after here. It is called
> to guarantee the LED is off during suspend to save more power. It
> could be lit up in the card host drivers(e.g. rtsx_usb_sdmmc.c)
> anytime whenever necessary.
>
> This has been asked may times. I'm considering putting some comment
> in next revision.
Yes, please do.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-03-28 7:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 10:44 [PATCH v5 0/3] Add modules for realtek USB card reader rogerable
2014-03-25 10:44 ` [PATCH v5 1/3] mfd: Add realtek USB card reader driver rogerable
2014-03-26 14:36 ` Oliver Neukum
[not found] ` <201403280231.s2S2VP8X017745@rtits1.realtek.com>
2014-03-28 3:33 ` Roger
2014-03-28 7:59 ` Lee Jones [this message]
2014-03-28 8:31 ` Oliver Neukum
2014-03-28 8:57 ` Roger
2014-03-25 10:44 ` [PATCH v5 2/3] mmc: Add realtek USB sdmmc host driver rogerable
2014-03-25 10:44 ` [PATCH v5 3/3] memstick: Add realtek USB memstick " rogerable
2014-04-01 3:20 ` Roger
2014-04-01 22:06 ` Andrew Morton
2014-04-02 15:16 ` Lee Jones
2014-04-08 8:06 ` Roger
2014-04-08 11:37 ` Lee Jones
2014-04-08 13:10 ` Roger
2014-04-08 13:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140328075942.GD17779@lee--X1 \
--to=lee.jones@linaro.org \
--cc=akpm@linux-foundation.org \
--cc=chris@printf.net \
--cc=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=maximlevitsky@gmail.com \
--cc=micky_ching@realsil.com.cn \
--cc=oakad@yahoo.com \
--cc=oneukum@suse.de \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=ulf.hansson@linaro.org \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).