From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbaC1KSd (ORCPT ); Fri, 28 Mar 2014 06:18:33 -0400 Received: from mail.karo-electronics.de ([81.173.242.67]:54822 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751055AbaC1KSa convert rfc822-to-8bit (ORCPT ); Fri, 28 Mar 2014 06:18:30 -0400 Date: Fri, 28 Mar 2014 11:18:05 +0100 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Huang Shijie Cc: Sascha Hauer , Fabio Estevam , Mark Rutland , Brian Norris , Russell King , Pawel Moll , Arnd Bergmann , Ian Campbell , Artem Bityutskiy , , , , Rob Herring , , Shawn Guo , Rob Landley , Kumar Gala , Shawn Guo , David Woodhouse , Sascha Hauer , Subject: Re: [PATCHv2 1/1] mtd: gpmi: make blockmark swapping optional Message-ID: <20140328111805.76b6513d@ipc1.ka-ro> In-Reply-To: <53354A46.9040807@freescale.com> References: <1395399017-19005-1-git-send-email-LW@KARO-electronics.de> <20140324095902.GB11377@localhost> <20140326095156.3e5585b8@ipc1.ka-ro> <5332AEE7.2040402@freescale.com> <20140326125502.0e8d0657@ipc1.ka-ro> <20140327095956.GA29623@localhost> <20140327132109.06258526@ipc1.ka-ro> <5334D9F7.2030001@freescale.com> <20140328091646.1ce03f90@ipc1.ka-ro> <53353524.9020605@freescale.com> <20140328090023.GB17250@pengutronix.de> <53354057.6030004@freescale.com> <20140328103147.3fdadfd7@ipc1.ka-ro> <53354A46.9040807@freescale.com> Organization: Ka-Ro electronics GmbH X-Mailer: Claws Mail 3.8.1 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Huang Shijie wrote: > 于 2014年03月28日 17:31, Lothar Waßmann 写道: > > Hi, > > > > Huang Shijie wrote: > >> 于 2014年03月28日 17:00, Sascha Hauer 写道: > >>> - disables swapping of BB marks in the FCB the ROM won't swap bytes. > >> We can not disable the swapping in the FCB in the imx28. > >> The DISBBM bit in the FCB does _NOT_ exit in the imx28's FCB. > >> > > The Linux kernel does not have any business with the FCB, so it is > > completely irrelevant for Linux whether byte swapping can be disabled > > in the FCB or not. > > > But the gpmi is relevant to the ROM. > the gpmi driver should keep consistency with the ROM. > > I do not object you add the swapping optional the gpmi driver(since it's > ok for imx50/imx6q/imx6sx), > i just object that you enable this feature for imx28. > We are talking about a Linux Kernel Driver here, not about a flashtool for i.MX28. It is a valid usecase for Linux not being able to write the bootloader, so there is no reason to disallow this feature in the driver code. Since it is a DT option it can be trivially switched on and off without having to change anything in the kernel. Lothar Waßmann -- ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Geschäftsführer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________