Re: [PATCH 1/1] Drivers: hid: hid-hyperv: Implement a stub raw_request() entry point

Re: [PATCH 1/1] Drivers: hid: hid-hyperv: Implement a stub raw_request() entry point

[Benjamin Tissoires]

On Mar 28 2014 or thereabouts, K. Y. Srinivasan wrote:
> commit 3c86726cfe38952f0366f86acfbbb025813ec1c2
> Author: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Date:   Thu Feb 20 15:24:49 2014 -0500
> 
>     HID: make .raw_request mandatory
> 
>     SET_REPORT and GET_REPORT are mandatory in the HID specification.
>     Make the corresponding API in hid-core mandatory too, which removes the
>     need to test against it in some various places.
> 
>     Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>     Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
>     Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> 
> Made .raw_request mandatory and broke the Hyper-V mouse driver. This patch
> fixes the problem.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>

Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>

Thanks for spotting and fixing this K. Y.

Cheers,
Benjamin

[PATCH 1/1] Drivers: hid: hid-hyperv: Implement a stub raw_request() entry point

[K. Y. Srinivasan]

commit 3c86726cfe38952f0366f86acfbbb025813ec1c2
Author: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Date:   Thu Feb 20 15:24:49 2014 -0500

    HID: make .raw_request mandatory

    SET_REPORT and GET_REPORT are mandatory in the HID specification.
    Make the corresponding API in hid-core mandatory too, which removes the
    need to test against it in some various places.

    Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
    Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
    Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Made .raw_request mandatory and broke the Hyper-V mouse driver. This patch
fixes the problem.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hid/hid-hyperv.c |   10 ++++++++++
 1 files changed, 10 insertions(+), 0 deletions(-)

diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
index c24908f..89a9234 100644
--- a/drivers/hid/hid-hyperv.c
+++ b/drivers/hid/hid-hyperv.c
@@ -460,12 +460,22 @@ static void mousevsc_hid_stop(struct hid_device *hid)
 {
 }
 
+static int mousevsc_hid_raw_request(struct hid_device *hid,
+				    unsigned char report_num,
+				    __u8 buf, size_t len,
+				    unsigned char rtype,
+				    int reqtype)
+{
+	return 0;
+}
+
 static struct hid_ll_driver mousevsc_ll_driver = {
 	.parse = mousevsc_hid_parse,
 	.open = mousevsc_hid_open,
 	.close = mousevsc_hid_close,
 	.start = mousevsc_hid_start,
 	.stop = mousevsc_hid_stop,
+	.raw_request = mousevsc_hid_raw_request,
 };
 
 static struct hid_driver mousevsc_hid_driver;
-- 
1.7.4.1

Re: [PATCH 1/1] Drivers: hid: hid-hyperv: Implement a stub raw_request() entry point

[Jiri Kosina]

On Fri, 28 Mar 2014, K. Y. Srinivasan wrote:

> commit 3c86726cfe38952f0366f86acfbbb025813ec1c2
> Author: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> Date:   Thu Feb 20 15:24:49 2014 -0500
> 
>     HID: make .raw_request mandatory
> 
>     SET_REPORT and GET_REPORT are mandatory in the HID specification.
>     Make the corresponding API in hid-core mandatory too, which removes the
>     need to test against it in some various places.
> 
>     Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>     Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
>     Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> 
> Made .raw_request mandatory and broke the Hyper-V mouse driver. This patch
> fixes the problem.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  drivers/hid/hid-hyperv.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> index c24908f..89a9234 100644
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -460,12 +460,22 @@ static void mousevsc_hid_stop(struct hid_device *hid)
>  {
>  }
>  
> +static int mousevsc_hid_raw_request(struct hid_device *hid,
> +				    unsigned char report_num,
> +				    __u8 buf, size_t len,

This should be __u8 *buf. I have fixed that and applied.

-- 
Jiri Kosina
SUSE Labs

RE: [PATCH 1/1] Drivers: hid: hid-hyperv: Implement a stub raw_request() entry point

[KY Srinivasan]

> -----Original Message-----
> From: Jiri Kosina [mailto:jkosina@suse.cz]
> Sent: Friday, March 28, 2014 6:43 PM
> To: KY Srinivasan
> Cc: gregkh@suse.de; linux-kernel@vger.kernel.org;
> devel@linuxdriverproject.org; ohering@suse.com;
> benjamin.tissoires@redhat.com; dh.herrmann@gmail.com
> Subject: Re: [PATCH 1/1] Drivers: hid: hid-hyperv: Implement a stub
> raw_request() entry point
> 
> On Fri, 28 Mar 2014, K. Y. Srinivasan wrote:
> 
> > commit 3c86726cfe38952f0366f86acfbbb025813ec1c2
> > Author: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > Date:   Thu Feb 20 15:24:49 2014 -0500
> >
> >     HID: make .raw_request mandatory
> >
> >     SET_REPORT and GET_REPORT are mandatory in the HID specification.
> >     Make the corresponding API in hid-core mandatory too, which removes
> the
> >     need to test against it in some various places.
> >
> >     Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> >     Reviewed-by: David Herrmann <dh.herrmann@gmail.com>
> >     Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> >
> > Made .raw_request mandatory and broke the Hyper-V mouse driver. This
> > patch fixes the problem.
> >
> > Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> > ---
> >  drivers/hid/hid-hyperv.c |   10 ++++++++++
> >  1 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c index
> > c24908f..89a9234 100644
> > --- a/drivers/hid/hid-hyperv.c
> > +++ b/drivers/hid/hid-hyperv.c
> > @@ -460,12 +460,22 @@ static void mousevsc_hid_stop(struct hid_device
> > *hid)  {  }
> >
> > +static int mousevsc_hid_raw_request(struct hid_device *hid,
> > +				    unsigned char report_num,
> > +				    __u8 buf, size_t len,
> 
> This should be __u8 *buf. I have fixed that and applied.

Thanks Jiri,

K. Y
> 
> --
> Jiri Kosina
> SUSE Labs