From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752095AbaC2RLG (ORCPT ); Sat, 29 Mar 2014 13:11:06 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12468 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751609AbaC2RLC (ORCPT ); Sat, 29 Mar 2014 13:11:02 -0400 Date: Sat, 29 Mar 2014 18:10:47 +0100 From: Jiri Olsa To: Don Zickus Cc: acme@ghostprotocols.net, LKML , jmario@redhat.com, fowles@inreach.com, Li Zefan Subject: Re: [PATCH 2/4] perf, kmem: Utilize the new generic cpunode_map Message-ID: <20140329171047.GC2022@krava.redhat.com> References: <1395689577-214654-1-git-send-email-dzickus@redhat.com> <1395689577-214654-3-git-send-email-dzickus@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1395689577-214654-3-git-send-email-dzickus@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 24, 2014 at 03:32:55PM -0400, Don Zickus wrote: > Use the previous patch implementation of cpunode_map for builtin-kmem.c > Should not be any functional difference. > > Cc: Li Zefan > Signed-off-by: Don Zickus > --- > tools/perf/builtin-kmem.c | 78 ++--------------------------------------------- > 1 file changed, 3 insertions(+), 75 deletions(-) > > diff --git a/tools/perf/builtin-kmem.c b/tools/perf/builtin-kmem.c > index 929462a..a61783a 100644 > --- a/tools/perf/builtin-kmem.c > +++ b/tools/perf/builtin-kmem.c > @@ -14,6 +14,7 @@ > #include "util/parse-options.h" > #include "util/trace-event.h" > #include "util/data.h" > +#include "util/cpumap.h" > > #include "util/debug.h" > > @@ -31,9 +32,6 @@ static int caller_lines = -1; > > static bool raw_ip; > > -static int *cpunode_map; > -static int max_cpu_num; > - > struct alloc_stat { > u64 call_site; > u64 ptr; > @@ -55,76 +53,6 @@ static struct rb_root root_caller_sorted; > static unsigned long total_requested, total_allocated; > static unsigned long nr_allocs, nr_cross_allocs; > > -#define PATH_SYS_NODE "/sys/devices/system/node" > - > -static int init_cpunode_map(void) > -{ > - FILE *fp; > - int i, err = -1; > - > - fp = fopen("/sys/devices/system/cpu/kernel_max", "r"); so the factored code from previous patches now reads the max_cpu_num value from: /sys/devices/system/cpu/possible is this intentional? I think we want to have separate patches for code changes and for changing the file with some comment. jirka