From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: "Jérôme Pinot" <ngc891@gmail.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Miller" <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] staging/ozwpan: coding style ether_addr_copy
Date: Sun, 30 Mar 2014 13:43:35 +0300 [thread overview]
Message-ID: <20140330104335.GG19296@mwanda> (raw)
In-Reply-To: <1396142606.21529.9.camel@joe-AO722>
On Sat, Mar 29, 2014 at 06:23:26PM -0700, Joe Perches wrote:
> On Sun, 2014-03-30 at 02:29 +0300, Dan Carpenter wrote:
> > These days in the kernel we treat checkpatch.pl and GCC
> > warnings the same so it sucks when they are something conditional.
>
> Treating checkpatch messages like gcc compilation warnings
> and failures has got to change.
>
> There is _no way_ checkpatch can have no false positives.
>
We could argue back and forth, but for now lets just revert the
ether_addr_copy() check because people ignore the alignement requirement
and it just encourages people to introduce bugs.
regards,
dan carpenter
prev parent reply other threads:[~2014-03-30 10:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140312100132.GA18954@star>
[not found] ` <20140312144533.GA3410@kroah.com>
[not found] ` <20140313012144.GD30138@star>
[not found] ` <20140313022821.GA9084@kroah.com>
[not found] ` <20140313153911.GA17881@star>
[not found] ` <20140328111801.GD6991@mwanda>
2014-03-28 13:08 ` [PATCH 3/3] staging/ozwpan: coding style ether_addr_copy Joe Perches
2014-03-29 23:29 ` Dan Carpenter
2014-03-30 1:23 ` Joe Perches
2014-03-30 10:43 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140330104335.GG19296@mwanda \
--to=dan.carpenter@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ngc891@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox