From: Dan Carpenter <dan.carpenter@oracle.com>
To: paulmcquad <paulmcquad@gmail.com>
Cc: gregkh@linuxfoundation.org, gamerh2o@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: Staging:et131x: change memcpy() ether_addr_copy()
Date: Mon, 31 Mar 2014 11:56:42 +0300 [thread overview]
Message-ID: <20140331085642.GL6991@mwanda> (raw)
In-Reply-To: <5335F74A.9020507@gmail.com>
On Fri, Mar 28, 2014 at 10:27:22PM +0000, paulmcquad wrote:
> >From 63f3c8948d5264ab22695502b201ff50edb9028d Mon Sep 17 00:00:00 2001
> From: Paul McQuade <paulmcquad@gmail.com>
> Date: Fri, 28 Mar 2014 22:16:22 +0000
> Subject: [PATCH] Staging:et131x: change memcpy() ether_addr_copy()
Don't include this header block.
>
> replace memcpy() with ether_addr_copy()
> make checkpatch.pl clean
Patch doesn't apply to linux-next.
> @@ -4337,7 +4337,7 @@ static void et131x_multicast(struct net_device *netdev)
> netdev_for_each_mc_addr(ha, netdev) {
> if (i == NIC_MAX_MCAST_LIST)
> break;
> - memcpy(adapter->multicast_list[i++], ha->addr, ETH_ALEN);
> + ether_addr_copy(adapter->multicast_list[i++], ha->addr, ETH_ALEN);
There is an indenting error here.
regards,
dan carpenter
next prev parent reply other threads:[~2014-03-31 8:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-28 22:27 Staging:et131x: change memcpy() ether_addr_copy() paulmcquad
2014-03-28 22:59 ` Joe Perches
2014-03-31 8:56 ` Dan Carpenter [this message]
2014-03-31 12:47 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331085642.GL6991@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gamerh2o@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmcquad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox