From: Andi Kleen <andi@firstfloor.org>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, Andi Kleen <andi@firstfloor.org>,
Josh Boyer <jwboyer@fedoraproject.org>,
Rob Landley <rob@landley.net>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] Add initcall_blacklist kernel parameter [v2]
Date: Mon, 31 Mar 2014 15:04:17 +0200 [thread overview]
Message-ID: <20140331130417.GG22728@two.firstfloor.org> (raw)
In-Reply-To: <1396270321-20007-1-git-send-email-prarit@redhat.com>
> do_initcall_level(level);
> +
> + list_for_each_safe(tmp, next, &blacklisted_initcalls) {
> + entry = list_entry(tmp, struct blacklist_entry, next);
> + free_bootmem(entry->buf, strlen(entry->buf));
> + free_bootmem(entry, sizeof(*entry));
Does that really work? At this point the bootmem allocator should
be already finished, so no memory will be freed.
For this case it's probably ok to leak it.
Alternatively you could use static arrays and storing pointer/len.
-Andi
next prev parent reply other threads:[~2014-03-31 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 12:52 [PATCH] Add initcall_blacklist kernel parameter [v2] Prarit Bhargava
2014-03-31 13:04 ` Andi Kleen [this message]
2014-03-31 13:36 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331130417.GG22728@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=jwboyer@fedoraproject.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=prarit@redhat.com \
--cc=rob@landley.net \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox