From: Dan Carpenter <dan.carpenter@oracle.com>
To: Denis Pithon <denis.pithon@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, khoroshilov@ispras.ru
Subject: Re: [PATCH] staging/wlan-ng fix small coding style issue
Date: Mon, 31 Mar 2014 16:42:27 +0300 [thread overview]
Message-ID: <20140331134227.GP6991@mwanda> (raw)
In-Reply-To: <1396271603-12142-1-git-send-email-denis.pithon@gmail.com>
On Mon, Mar 31, 2014 at 03:13:23PM +0200, Denis Pithon wrote:
> Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Changeglog sucks. It doesn't even exist, actually. What coding style
issue did you fix?
> ---
> drivers/staging/wlan-ng/prism2usb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
> index 4739c14..ccb2c2e 100644
> --- a/drivers/staging/wlan-ng/prism2usb.c
> +++ b/drivers/staging/wlan-ng/prism2usb.c
> @@ -293,6 +293,7 @@ static int prism2sta_suspend(struct usb_interface *interface,
> hfa384x_t *hw = NULL;
> wlandevice_t *wlandev;
> wlandev = (wlandevice_t *) usb_get_intfdata(interface);
> +
> if (!wlandev)
> return -ENODEV;
The blank line should go be one line earlier.
wlandevice_t *wlandev;
[blank]
wlandev = (wlandevice_t *) usb_get_intfdata(interface);
>
> @@ -315,6 +316,7 @@ static int prism2sta_resume(struct usb_interface *interface)
> hfa384x_t *hw = NULL;
> wlandevice_t *wlandev;
> wlandev = (wlandevice_t *) usb_get_intfdata(interface);
> +
Same.
> if (!wlandev)
> return -ENODEV;
regards,
dan carpenter
prev parent reply other threads:[~2014-03-31 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 13:13 [PATCH] staging/wlan-ng fix small coding style issue Denis Pithon
2014-03-31 13:42 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331134227.GP6991@mwanda \
--to=dan.carpenter@oracle.com \
--cc=denis.pithon@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=khoroshilov@ispras.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox