* [PATCH] staging/wlan-ng fix small coding style issue
@ 2014-03-31 13:13 Denis Pithon
2014-03-31 13:42 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Denis Pithon @ 2014-03-31 13:13 UTC (permalink / raw)
To: gregkh; +Cc: khoroshilov, devel, linux-kernel
Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
---
drivers/staging/wlan-ng/prism2usb.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
index 4739c14..ccb2c2e 100644
--- a/drivers/staging/wlan-ng/prism2usb.c
+++ b/drivers/staging/wlan-ng/prism2usb.c
@@ -293,6 +293,7 @@ static int prism2sta_suspend(struct usb_interface *interface,
hfa384x_t *hw = NULL;
wlandevice_t *wlandev;
wlandev = (wlandevice_t *) usb_get_intfdata(interface);
+
if (!wlandev)
return -ENODEV;
@@ -315,6 +316,7 @@ static int prism2sta_resume(struct usb_interface *interface)
hfa384x_t *hw = NULL;
wlandevice_t *wlandev;
wlandev = (wlandevice_t *) usb_get_intfdata(interface);
+
if (!wlandev)
return -ENODEV;
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging/wlan-ng fix small coding style issue
2014-03-31 13:13 [PATCH] staging/wlan-ng fix small coding style issue Denis Pithon
@ 2014-03-31 13:42 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-03-31 13:42 UTC (permalink / raw)
To: Denis Pithon; +Cc: gregkh, devel, linux-kernel, khoroshilov
On Mon, Mar 31, 2014 at 03:13:23PM +0200, Denis Pithon wrote:
> Signed-off-by: Denis Pithon <denis.pithon@gmail.com>
Changeglog sucks. It doesn't even exist, actually. What coding style
issue did you fix?
> ---
> drivers/staging/wlan-ng/prism2usb.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
> index 4739c14..ccb2c2e 100644
> --- a/drivers/staging/wlan-ng/prism2usb.c
> +++ b/drivers/staging/wlan-ng/prism2usb.c
> @@ -293,6 +293,7 @@ static int prism2sta_suspend(struct usb_interface *interface,
> hfa384x_t *hw = NULL;
> wlandevice_t *wlandev;
> wlandev = (wlandevice_t *) usb_get_intfdata(interface);
> +
> if (!wlandev)
> return -ENODEV;
The blank line should go be one line earlier.
wlandevice_t *wlandev;
[blank]
wlandev = (wlandevice_t *) usb_get_intfdata(interface);
>
> @@ -315,6 +316,7 @@ static int prism2sta_resume(struct usb_interface *interface)
> hfa384x_t *hw = NULL;
> wlandevice_t *wlandev;
> wlandev = (wlandevice_t *) usb_get_intfdata(interface);
> +
Same.
> if (!wlandev)
> return -ENODEV;
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-31 13:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-31 13:13 [PATCH] staging/wlan-ng fix small coding style issue Denis Pithon
2014-03-31 13:42 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox