public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Rocco Folino <lordzen87@gmail.com>
Cc: aaro.koskinen@iki.fi, devel@driverdev.osuosl.org,
	gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	Joe Perches <joe@perches.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] staging: octeon-usb: Fixed code style issues
Date: Mon, 31 Mar 2014 18:06:38 +0300	[thread overview]
Message-ID: <20140331150638.GQ6991@mwanda> (raw)
In-Reply-To: <1396269280-32665-1-git-send-email-lordzen87@gmail.com>

Hi Joe, Andy,

On Mon, Mar 31, 2014 at 02:34:40PM +0200, Rocco Folino wrote:
> Fixed bit fields code style issues
> 
> Signed-off-by: Rocco Folino <lordzen87@gmail.com>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.h | 486 ++++++++++++++++----------------
>  1 file changed, 243 insertions(+), 243 deletions(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.h b/drivers/staging/octeon-usb/octeon-hcd.h
> index 42fe4fe..c534e317 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.h
> +++ b/drivers/staging/octeon-usb/octeon-hcd.h
> @@ -143,13 +143,13 @@ union cvmx_usbcx_gahbcfg {
>  	 *	* 1'b1: Unmask the interrupt assertion to the application.
>  	 */
>  	struct cvmx_usbcx_gahbcfg_s {
> -		uint32_t reserved_9_31	: 23;
> -		uint32_t ptxfemplvl	: 1;
> -		uint32_t nptxfemplvl	: 1;
> -		uint32_t reserved_6_6	: 1;
> -		uint32_t dmaen		: 1;
> -		uint32_t hbstlen	: 4;
> -		uint32_t glblintrmsk	: 1;
> +		uint32_t reserved_9_31:23;
> +		uint32_t ptxfemplvl:1;
> +		uint32_t nptxfemplvl:1;
> +		uint32_t reserved_6_6:1;
> +		uint32_t dmaen:1;
> +		uint32_t hbstlen:4;
> +		uint32_t glblintrmsk:1;
>  	} s;


The warning here is:

ERROR: spaces prohibited around that ':' (ctx:WxW)

I have done a kernel wide search for these warnings and I think we
should disable this warning.  It has too many false positives like this.

regards,
dan carpenter


  parent reply	other threads:[~2014-03-31 15:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 12:34 [PATCH] staging: octeon-usb: Fixed code style issues Rocco Folino
2014-03-31 12:46 ` Dan Carpenter
2014-03-31 15:06 ` Dan Carpenter [this message]
2014-03-31 15:31   ` [RFC] quiet checkpatch style recommendation about no spaces around bitfield : Joe Perches
2014-03-31 19:44     ` Dan Carpenter
2014-03-31 20:56     ` Andrew Morton
2014-04-03 18:28       ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140331150638.GQ6991@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=akpm@linux-foundation.org \
    --cc=apw@canonical.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lordzen87@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox