From: Greg KH <gregkh@linuxfoundation.org>
To: Thomas Vegas <thomas_75@safe-mail.net>
Cc: joe@perches.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: serqt_usb2: Fix coding style issues.
Date: Mon, 31 Mar 2014 08:55:12 -0700 [thread overview]
Message-ID: <20140331155512.GA7217@kroah.com> (raw)
In-Reply-To: <f10faefdec9dffd231e8e020c2b6af38@mwinf5d69.me-wanadoo.net>
On Mon, Mar 31, 2014 at 08:51:04AM +0200, Thomas Vegas wrote:
> Add blank lines after declarations and cleanup initializations.
Patches should do only 1 thing, not multiple things if at all possible.
So this should be 2 patches, not one. Care to break it up like that and
resend 2 patches instead?
thanks,
greg k-h
prev parent reply other threads:[~2014-03-31 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 6:51 [PATCH v2] staging: serqt_usb2: Fix coding style issues Thomas Vegas
2014-03-31 15:55 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331155512.GA7217@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas_75@safe-mail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox