public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andrey Wagin <avagin@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"Shawn Landden" <shawn@churchofgit.com>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Павел Емельянов" <xemul@parallels.com>
Subject: Re: [rfc 2/2] docs: procfs -- Document timerfd output
Date: Mon, 31 Mar 2014 22:43:16 +0400	[thread overview]
Message-ID: <20140331184316.GM4872@moon> (raw)
In-Reply-To: <CANaxB-wY_=1QRAfvJxZjKPY6ZkgHuZOQvRm0FVktbj6-tL1CbA@mail.gmail.com>

On Mon, Mar 31, 2014 at 10:31:02PM +0400, Andrey Wagin wrote:
> > +       Timerfd files
> > +       ~~~~~~~~~~~~~
> > +       pos:    0
> > +       flags:  02
> > +       mnt_id: 9
> > +       clockid: 0 ticks: 0
> 
> I would prefer to print "tick" on a separate line.

Sure, this is not a problem to make it so.

> And we can print the current setting of the timer here. It can be
> useful not only for CRIU but for other users too.
> 
> it_value: (5, 149234)
> it_interval: (10, 0)

Yeah, moreover I think this is needed because if the timer is expired
and it's interval timer the gettime method will rearm it which we
defenitely not needed. Will update, thanks.

      reply	other threads:[~2014-03-31 18:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-31 17:54 [rfc 0/2] timerfd -- implement missing parts to checkpoint and restore timerfd state Cyrill Gorcunov
2014-03-31 17:54 ` [rfc 1/2] timerfd: Implement show_fdinfo method Cyrill Gorcunov
2014-03-31 19:43   ` Thomas Gleixner
2014-03-31 19:51     ` Cyrill Gorcunov
2014-03-31 17:54 ` [rfc 2/2] docs: procfs -- Document timerfd output Cyrill Gorcunov
2014-03-31 18:31   ` Andrey Wagin
2014-03-31 18:43     ` Cyrill Gorcunov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140331184316.GM4872@moon \
    --to=gorcunov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=avagin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shawn@churchofgit.com \
    --cc=tglx@linutronix.de \
    --cc=xemul@parallels.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox