From: Andi Kleen <ak@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
Gleb Natapov <gleb@redhat.com>, Peter Anvin <hpa@zytor.com>,
hubicka@ucw.cz,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Jaroslav Kysela <perex@perex.cz>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [GIT PULL] x86 LTO changes for v3.15
Date: Mon, 31 Mar 2014 16:03:47 -0700 [thread overview]
Message-ID: <20140331230347.GH32556@tassilo.jf.intel.com> (raw)
In-Reply-To: <CA+55aFwccMZNgHA_xS_+cLNPqEjAt4qm2LYK_WLU0XbeDOoa=g@mail.gmail.com>
> So I think that adding "visible" to asmlinkage is actively wrong and
> misguided. And the compiler even told you so, but somebody then chose
> to ignore the compiler telling them that they did stupid things.
Hi Linus,
In principle you're right. asmlinkage does not mean visible today.
However with LTO pretty much all asmlinkages have to become
visible, as they are used by assembler code and we need to
tell that to the compiler, otherwise it'll optimize it away.
So I abused asmlinkage for this.
The alternative would be to add __visible everywhere we
have asmlinkage today. I thought it was the lesser evil
to just add it implicitly.
If you prefer to do it explicitely I can send
patches (it would be a very mechanic, long and boring
tree sweep ...).
I can send patches for the warnings. Usually the code
throwing warnings for this has some issue anyways,
or the asmlinkage is not really needed.
Please let me know what you prefer.
-Andi
next prev parent reply other threads:[~2014-03-31 23:04 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 21:05 [GIT PULL] x86 LTO changes for v3.15 H. Peter Anvin
2014-03-31 21:54 ` Linus Torvalds
2014-03-31 23:03 ` Andi Kleen [this message]
2014-04-01 0:17 ` Linus Torvalds
2014-04-01 0:33 ` Linus Torvalds
2014-04-01 18:54 ` H. Peter Anvin
2014-04-01 19:15 ` Linus Torvalds
2014-04-01 19:43 ` H. Peter Anvin
2014-04-02 0:01 ` Steven Rostedt
2014-04-02 0:35 ` Linus Torvalds
2014-04-02 12:33 ` Steven Rostedt
2014-04-02 17:10 ` H. Peter Anvin
2014-04-02 17:59 ` Steven Rostedt
2014-04-01 1:09 ` Andi Kleen
2014-04-01 1:35 ` H. Peter Anvin
2014-04-01 2:26 ` Linus Torvalds
2014-04-01 20:49 ` Paul Bolle
2014-04-01 23:17 ` Andi Kleen
2014-04-02 8:29 ` Paul Bolle
2014-04-16 8:53 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140331230347.GH32556@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=gleb@redhat.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=hubicka@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=perex@perex.cz \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox