From: Andi Kleen <ak@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
Gleb Natapov <gleb@redhat.com>, Peter Anvin <hpa@zytor.com>,
hubicka@ucw.cz,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Jaroslav Kysela <perex@perex.cz>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [GIT PULL] x86 LTO changes for v3.15
Date: Mon, 31 Mar 2014 18:09:01 -0700 [thread overview]
Message-ID: <20140401010901.GJ32556@tassilo.jf.intel.com> (raw)
In-Reply-To: <CA+55aFyOPkCO7Cpf7pG1wD3QL0CVwKrcf+zKVka51ROABFGn-w@mail.gmail.com>
> - don't do the __visible as part of asmlinkage, because it really is
> conceptually wrong
Ok.
>
> - add the visible to the SYSCALL_DEFINEx() macros
I think SYSCALL_DEFINE actually doesn't need it, as the syscall
tables are visible in C. Only the syscall table itself
needs to be visible.
> and after that I strongly suspect that there will be only a handful of
> cases left that are called from assembly language and that aren't
> system calls. Things like "printk()" and friends that are really
> special. They'd need a few manual "__visible" annotations.
Ok. I think it's more than a handful though.
I'll cook up a patch.
> See above: I can pretty much guarantee that you should *not* need do
> any crazy automated sweeps. Because you shouldn't need "__visible" at
> the declarations in the header files, only at the definition of the
> function, right?
Yes that's right.
-Andi
next prev parent reply other threads:[~2014-04-01 1:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 21:05 [GIT PULL] x86 LTO changes for v3.15 H. Peter Anvin
2014-03-31 21:54 ` Linus Torvalds
2014-03-31 23:03 ` Andi Kleen
2014-04-01 0:17 ` Linus Torvalds
2014-04-01 0:33 ` Linus Torvalds
2014-04-01 18:54 ` H. Peter Anvin
2014-04-01 19:15 ` Linus Torvalds
2014-04-01 19:43 ` H. Peter Anvin
2014-04-02 0:01 ` Steven Rostedt
2014-04-02 0:35 ` Linus Torvalds
2014-04-02 12:33 ` Steven Rostedt
2014-04-02 17:10 ` H. Peter Anvin
2014-04-02 17:59 ` Steven Rostedt
2014-04-01 1:09 ` Andi Kleen [this message]
2014-04-01 1:35 ` H. Peter Anvin
2014-04-01 2:26 ` Linus Torvalds
2014-04-01 20:49 ` Paul Bolle
2014-04-01 23:17 ` Andi Kleen
2014-04-02 8:29 ` Paul Bolle
2014-04-16 8:53 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401010901.GJ32556@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=gleb@redhat.com \
--cc=hpa@linux.intel.com \
--cc=hpa@zytor.com \
--cc=hubicka@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=pbonzini@redhat.com \
--cc=perex@perex.cz \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox