From: Hans-Christian Egtvedt <egtvedt@samfundet.no>
To: Ramkumar Ramachandra <artagnon@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Haavard Skinnemoen <hskinnemoen@gmail.com>
Subject: Re: [PATCH v2] avr32: replace simple_strtoul() with kstrtoul()
Date: Tue, 1 Apr 2014 09:08:56 +0200 [thread overview]
Message-ID: <20140401070856.GA22185@samfundet.no> (raw)
In-Reply-To: <1396312962-12483-1-git-send-email-artagnon@gmail.com>
Around Mon 31 Mar 2014 20:42:42 -0400 or thereabout, Ramkumar Ramachandra wrote:
> simple_strtoul() is marked for obsoletion; use the newer and more
> pleasant kstrtoul() in its place.
>
> Cc: Alexey Dobriyan <adobriyan@gmail.com>
> Cc: Haavard Skinnemoen <hskinnemoen@gmail.com>
> Cc: Hans-Christian Egtvedt <egtvedt@samfundet.no>
> Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
> ---
> arch/avr32/kernel/cpu.c | 48 ++++++++++++++++++++++++++----------------------
> 1 file changed, 26 insertions(+), 22 deletions(-)
>
> diff --git a/arch/avr32/kernel/cpu.c b/arch/avr32/kernel/cpu.c
<snipp diff>
> @@ -61,11 +63,11 @@ static ssize_t store_pc0count(struct device *dev,
> const char *buf, size_t count)
> {
> unsigned long val;
> - char *endp;
> + int ret;
>
> - val = simple_strtoul(buf, &endp, 0);
> - if (endp == buf)
> - return -EINVAL;
> + ret = kstroul(buf, 0, &val);
I fixed this typo to kstrtoul.
<snipp diff>
--
mvh
Hans-Christian Egtvedt
prev parent reply other threads:[~2014-04-01 7:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-18 21:25 [PATCH] avr32: replace simple_strtoul() with kstrtoul() Ramkumar Ramachandra
2014-04-01 0:42 ` [PATCH v2] " Ramkumar Ramachandra
2014-04-01 7:05 ` Hans-Christian Egtvedt
2014-04-01 7:08 ` Hans-Christian Egtvedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401070856.GA22185@samfundet.no \
--to=egtvedt@samfundet.no \
--cc=adobriyan@gmail.com \
--cc=artagnon@gmail.com \
--cc=hskinnemoen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox