RE: [PATCHv2 2/2] watchdog: imx2_wdt: Add big-endian support

Li.Xiubo
2014-04-01T02:24:18Z

> > It's actually the following ones first, which will support 16-bits
> > Values for regmap-mmio:
> >
> > https://patchwork.kernel.org/patch/3896321/
> > https://patchwork.kernel.org/patch/3896331/
> > https://patchwork.kernel.org/patch/3901021/
> >
> > And the then the following one, which will support the LE endian:
> > http://www.spinics.net/lists/kernel/msg1714375.html
> >
> So what is the plan for this patch ? Seems to me it would make more sense
> to convert the driver to regmap.
>

@Guenter, @Mark,

Yes, I do think so too and there has already regmap-mmio version patch
Series about the IMX2 Watchdog driver, but those regmap patches for
supporting the 16-bit values are in Mark's tree and the IMX2 Watchdog
will depend on them.

How to deal with this situation ?

The regmap patches depended by IMX2 Watchdog:

1, https://patchwork.kernel.org/patch/3896321/ ===> <applied>
regmap: mmio: add regmap_mmio_{regsize, count}_check.
https://patchwork.kernel.org/patch/3896331/ ===> <applied>
regmap: mmio: Add support for 1/2/8 bytes wide register address.
https://patchwork.kernel.org/patch/3901021/ ===> <applied>
regmap: mmio: Add regmap_mmio_regbits_check.

2, The above three and this one are a must.
https://patchwork.kernel.org/patch/3912671/ ===> <pending>
regmap: mmio: Fix the bug of 'offset' value parsing.

3, The following ones are not a must, but will make the IMX2
Watchdog much simplifier.
https://patchwork.kernel.org/patch/3912401/ ===> <pending>
regmap: implement LE formatting/parsing for 16/32-bit values.
https://patchwork.kernel.org/patch/3912751/ ===> <pending>
regmap: add DT endianness binding support.
https://patchwork.kernel.org/patch/3912741/ ===> <pending>
regmap: Add the DT binding documentation for endianness

The above all have been test using SAI(32-bit regmap-mmio),
SGTL5000(codec 16-bit regmap-i2c) and IMX2 Watchdog(16-bit
regmap-mmio).

I'll send the regmap-mmio based patch series for IMX2 Watchdog.

Thanks,

Best Regards,
Xiubo