From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Guido Martínez" <guido@vanguardiasur.com.ar>
Cc: linux-kernel@vger.kernel.org,
"Greg KH" <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
"Ezequiel García" <ezequiel@vanguardiasur.com.ar>,
"Walter Lozano" <walter@vanguardiasur.com.ar>,
"Forest Bond" <forest@alittletooquiet.net>
Subject: Re: [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros
Date: Tue, 1 Apr 2014 17:02:54 +0300 [thread overview]
Message-ID: <20140401140254.GS6991@mwanda> (raw)
In-Reply-To: <1396356733-5344-2-git-send-email-guido@vanguardiasur.com.ar>
On Tue, Apr 01, 2014 at 09:52:11AM -0300, Guido Martínez wrote:
> Parenthesize both macros so they will not break program logic if used
> within another 'if'. Also fix a usage of DBG_PRT with a missing
> semicolon.
>
> Signed-off-by: Guido Martínez <guido@vanguardiasur.com.ar>
> ---
> drivers/staging/vt6655/device.h | 4 ++--
> drivers/staging/vt6655/wpactl.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> index 062c3a3..483b017 100644
> --- a/drivers/staging/vt6655/device.h
> +++ b/drivers/staging/vt6655/device.h
> @@ -148,8 +148,8 @@
>
> /*--------------------- Export Types ------------------------------*/
>
> -#define DBG_PRT(l, p, args...) { if (l <= msglevel) printk(p, ##args); }
> -#define PRINT_K(p, args...) { if (PRIVATE_Message) printk(p, ##args); }
> +#define DBG_PRT(l, p, args...) ({ if (l <= msglevel) printk(p, ##args); })
> +#define PRINT_K(p, args...) ({ if (PRIVATE_Message) printk(p, ##args); })
Use a do { } while(0) for this.
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-01 14:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 12:52 [PATCH 0/3] staging: vt6655: style fixes Guido Martínez
2014-04-01 12:52 ` [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros Guido Martínez
2014-04-01 14:02 ` Dan Carpenter [this message]
2014-04-01 16:33 ` Greg KH
2014-04-01 16:56 ` Guido Martínez
2014-04-01 17:06 ` Greg KH
2014-04-01 12:52 ` [PATCH 2/3] staging: vt6655: remove dead code Guido Martínez
2014-04-01 14:19 ` Dan Carpenter
2014-04-01 12:52 ` [PATCH 3/3] staging: vt6655: fix checkpatch bracing issues Guido Martínez
2014-04-01 14:13 ` Dan Carpenter
2014-04-01 14:19 ` Guido Martínez
2014-04-02 17:53 ` [PATCH v2 0/4] staging: vt6655: style fixes Guido Martínez
2014-04-02 17:53 ` [PATCH v2 1/4] staging: vt6655: fix DBG_PRT and PRINT_K macros Guido Martínez
2014-04-02 17:53 ` [PATCH v2 2/4] staging: vt6655: remove mention of nonexistent function CARDbSetBasicRate Guido Martínez
2014-04-02 17:53 ` [PATCH v2 3/4] staging: vt6655: remove dead code Guido Martínez
2014-04-18 23:09 ` Greg KH
2014-04-19 19:43 ` Guido Martínez
2014-04-02 17:53 ` [PATCH v2 4/4] staging: vt6655: fix checkpatch bracing issues Guido Martínez
2014-04-02 18:09 ` [PATCH v2 0/4] staging: vt6655: style fixes Dan Carpenter
2014-04-03 0:15 ` Ezequiel García
2014-04-19 19:44 ` [PATCH v3 0/2] " Guido Martínez
2014-04-19 19:44 ` [PATCH v3 1/2] staging: vt6655: remove dead code Guido Martínez
2014-04-19 19:45 ` [PATCH v3 2/2] staging: vt6655: fix checkpatch bracing issues Guido Martínez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401140254.GS6991@mwanda \
--to=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=guido@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=walter@vanguardiasur.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox