From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Guido Martínez" <guido@vanguardiasur.com.ar>
Cc: linux-kernel@vger.kernel.org,
"Greg KH" <gregkh@linuxfoundation.org>,
driverdev-devel@linuxdriverproject.org,
"Ezequiel García" <ezequiel@vanguardiasur.com.ar>,
"Walter Lozano" <walter@vanguardiasur.com.ar>,
"Forest Bond" <forest@alittletooquiet.net>
Subject: Re: [PATCH 2/3] staging: vt6655: remove dead code
Date: Tue, 1 Apr 2014 17:19:51 +0300 [thread overview]
Message-ID: <20140401141951.GU6991@mwanda> (raw)
In-Reply-To: <1396356733-5344-3-git-send-email-guido@vanguardiasur.com.ar>
On Tue, Apr 01, 2014 at 09:52:12AM -0300, Guido Martínez wrote:
> @@ -2205,11 +2203,8 @@ bool BBbVT3253Init(PSDevice pDevice)
> //}}
> bResult &= BBbWriteEmbedded(dwIoBase, 0xb0, 0x58);
>
> - for (ii = 0; ii < CB_VT3253B0_AGC; ii++) {
> + for (ii = 0; ii < CB_VT3253B0_AGC; ii++)
> bResult &= BBbWriteEmbedded(dwIoBase, byVT3253B0_AGC[ii][0], byVT3253B0_AGC[ii][1]);
> - }
This isn't "deleting dead code". Do it in a separate patch.
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-01 14:20 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-01 12:52 [PATCH 0/3] staging: vt6655: style fixes Guido Martínez
2014-04-01 12:52 ` [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros Guido Martínez
2014-04-01 14:02 ` Dan Carpenter
2014-04-01 16:33 ` Greg KH
2014-04-01 16:56 ` Guido Martínez
2014-04-01 17:06 ` Greg KH
2014-04-01 12:52 ` [PATCH 2/3] staging: vt6655: remove dead code Guido Martínez
2014-04-01 14:19 ` Dan Carpenter [this message]
2014-04-01 12:52 ` [PATCH 3/3] staging: vt6655: fix checkpatch bracing issues Guido Martínez
2014-04-01 14:13 ` Dan Carpenter
2014-04-01 14:19 ` Guido Martínez
2014-04-02 17:53 ` [PATCH v2 0/4] staging: vt6655: style fixes Guido Martínez
2014-04-02 17:53 ` [PATCH v2 1/4] staging: vt6655: fix DBG_PRT and PRINT_K macros Guido Martínez
2014-04-02 17:53 ` [PATCH v2 2/4] staging: vt6655: remove mention of nonexistent function CARDbSetBasicRate Guido Martínez
2014-04-02 17:53 ` [PATCH v2 3/4] staging: vt6655: remove dead code Guido Martínez
2014-04-18 23:09 ` Greg KH
2014-04-19 19:43 ` Guido Martínez
2014-04-02 17:53 ` [PATCH v2 4/4] staging: vt6655: fix checkpatch bracing issues Guido Martínez
2014-04-02 18:09 ` [PATCH v2 0/4] staging: vt6655: style fixes Dan Carpenter
2014-04-03 0:15 ` Ezequiel García
2014-04-19 19:44 ` [PATCH v3 0/2] " Guido Martínez
2014-04-19 19:44 ` [PATCH v3 1/2] staging: vt6655: remove dead code Guido Martínez
2014-04-19 19:45 ` [PATCH v3 2/2] staging: vt6655: fix checkpatch bracing issues Guido Martínez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140401141951.GU6991@mwanda \
--to=dan.carpenter@oracle.com \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=guido@vanguardiasur.com.ar \
--cc=linux-kernel@vger.kernel.org \
--cc=walter@vanguardiasur.com.ar \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox