* [PATCH] staging: lirc: remove redundant NULL check in unregister_from_lirc()
@ 2014-04-02 9:49 Daeseok Youn
2014-04-02 9:50 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Daeseok Youn @ 2014-04-02 9:49 UTC (permalink / raw)
To: m.chehab
Cc: jarod, gregkh, dan.carpenter, paulmck, mtrompou, bernat.ada,
linux-media, devel, linux-kernel
"ir" is already checked before calling unregister_from_lirc().
Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
---
drivers/staging/media/lirc/lirc_igorplugusb.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c b/drivers/staging/media/lirc/lirc_igorplugusb.c
index f508a13..e93e1c2 100644
--- a/drivers/staging/media/lirc/lirc_igorplugusb.c
+++ b/drivers/staging/media/lirc/lirc_igorplugusb.c
@@ -222,12 +222,6 @@ static int unregister_from_lirc(struct igorplug *ir)
struct lirc_driver *d;
int devnum;
- if (!ir) {
- dev_err(&ir->usbdev->dev,
- "%s: called with NULL device struct!\n", __func__);
- return -EINVAL;
- }
-
devnum = ir->devnum;
d = ir->d;
--
1.7.4.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: lirc: remove redundant NULL check in unregister_from_lirc()
2014-04-02 9:49 [PATCH] staging: lirc: remove redundant NULL check in unregister_from_lirc() Daeseok Youn
@ 2014-04-02 9:50 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2014-04-02 9:50 UTC (permalink / raw)
To: Daeseok Youn
Cc: m.chehab, jarod, gregkh, paulmck, mtrompou, bernat.ada,
linux-media, devel, linux-kernel
On Wed, Apr 02, 2014 at 02:49:03AM -0700, Daeseok Youn wrote:
>
> "ir" is already checked before calling unregister_from_lirc().
>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-02 9:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-02 9:49 [PATCH] staging: lirc: remove redundant NULL check in unregister_from_lirc() Daeseok Youn
2014-04-02 9:50 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox