public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	silentquote@gmail.com
Subject: Re: [PATCH] driver: staging: wlan-ng: Fixed coding style
Date: Wed, 2 Apr 2014 15:28:51 -0700	[thread overview]
Message-ID: <20140402222851.GA31598@kroah.com> (raw)
In-Reply-To: <1396477016-30951-1-git-send-email-shehabaldin.sherif@gmail.com>

On Thu, Apr 03, 2014 at 12:16:56AM +0200, Sherif Shehab Aldin wrote:
> Fixed coding style for hfa384x_usb.c

You do a lot of different types of cleanup in this patch, you are going
to have to be more specific.

Also, only do 1 thing per patch, I see whitespace cleanups, typedef
removal and other things here.  Please break it up into a series of
patches, each doing one thing.

thanks,

greg k-h

  reply	other threads:[~2014-04-02 22:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-02 22:16 [PATCH] driver: staging: wlan-ng: Fixed coding style Sherif Shehab Aldin
2014-04-02 22:28 ` Greg KH [this message]
2014-04-02 23:20   ` Sherif

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140402222851.GA31598@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shehabaldin.sherif@gmail.com \
    --cc=silentquote@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox