From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: neelegup@linux.vnet.ibm.com, benh@kernel.crashing.org
Subject: Re: powerpc/powernv: Enable reading and updating of system parameters
Date: Thu, 3 Apr 2014 00:49:30 -0400 [thread overview]
Message-ID: <20140403044930.GA10707@redhat.com> (raw)
In-Reply-To: <20140402205401.9031B660EE0@gitolite.kernel.org>
On Wed, Apr 02, 2014 at 08:54:01PM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=4029cd66545f0a45258eda5313b7559bfeaaaae4
> Commit: 4029cd66545f0a45258eda5313b7559bfeaaaae4
> Parent: 8d724823220862ce289be3b50119235e03537597
> Author: Neelesh Gupta <neelegup@linux.vnet.ibm.com>
> AuthorDate: Fri Mar 7 11:02:09 2014 +0530
> Committer: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> CommitDate: Mon Mar 24 09:47:30 2014 +1100
>
> powerpc/powernv: Enable reading and updating of system parameters
>
> This patch enables reading and updating of system parameters through
> OPAL call.
>
...
> + /* If the parameter is read-only or read-write */
> + switch (perm[i] & 3) {
> + case OPAL_SYSPARAM_READ:
> + attr[i].kobj_attr.attr.mode = S_IRUGO;
> + break;
> + case OPAL_SYSPARAM_WRITE:
> + attr[i].kobj_attr.attr.mode = S_IWUGO;
> + break;
> + case OPAL_SYSPARAM_RW:
> + attr[i].kobj_attr.attr.mode = S_IRUGO | S_IWUGO;
> + break;
> + default:
> + break;
Is world-writable really appropriate for this ?
Dave
parent reply other threads:[~2014-04-03 4:50 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20140402205401.9031B660EE0@gitolite.kernel.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403044930.GA10707@redhat.com \
--to=davej@redhat.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neelegup@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox