From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, silentquote@gmail.com
Subject: Re: [PATCH 2/2] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c
Date: Thu, 3 Apr 2014 10:41:01 +0300 [thread overview]
Message-ID: <20140403074101.GX6991@mwanda> (raw)
In-Reply-To: <1396484754-32500-1-git-send-email-shehabaldin.sherif@gmail.com>
On Thu, Apr 03, 2014 at 02:25:54AM +0200, Sherif Shehab Aldin wrote:
> Removed unnecessary typedefs from hfa384x_usb.c
>
> Signed-off-by: Sherif Shehab Aldin <shehabaldin.sherif@gmail.com>
You've broken this patch set up in a wrong way. It should have just
been one patch. Don't introduce a warning and fix it later. The two
changes are closely related so they fall under the one thing per patch
rule.
The subject for this patch is nonsense because it fixes a long line. I
can see how you meant is as in you were fixing up the typedef patch that
context will be lost in the final git log.
regards,
dan carpenter
prev parent reply other threads:[~2014-04-03 7:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 0:25 [PATCH 2/2] driver: staging: wlan-ng: Removed unnecessary typedefs from hfa384x_usb.c Sherif Shehab Aldin
2014-04-03 7:41 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140403074101.GX6991@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shehabaldin.sherif@gmail.com \
--cc=silentquote@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox