Re: [RFC PATCH] cmdline: Hide "debug" from /proc/cmdline

Steven Rostedt
2014-04-04T19:44:32Z

On Fri, 4 Apr 2014 11:51:39 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Fri, 4 Apr 2014 11:42:51 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> > Most users will never notice. The whole "writable /dev/kmsg" may go
> > back to 2002, but there aren't _that_ many users, and pretty much all
> > I've ever seen tend to write the occasional "I started up" messages or
> > other very small notes. I had to write a test-script to trigger even
> > the (very draconian) default ratelimits.
>
> Is there anything here that we really need to fix? What goes wrong if
> we leave kmsg as-is and systemd gets fixed?

I saw one commenter say that this was a kernel bug because writing to
kmsg shouldn't cause the system to hang.

The rate-limit patch would go along with that idea, and I honestly
think it would be good to rate-limit it in case something else breaks
and starts spamming kmsg.

-- Steve