Re: [PATCH] staging: octeon-usb: Fixed code style issues

Dan Carpenter
2014-03-31T15:07:04Z

Hi Joe, Andy,

On Mon, Mar 31, 2014 at 02:34:40PM +0200, Rocco Folino wrote:
> Fixed bit fields code style issues
>
> Signed-off-by: Rocco Folino <lordzen87@gmail.com>
> ---
> drivers/staging/octeon-usb/octeon-hcd.h | 486 ++++++++++++++++----------------
> 1 file changed, 243 insertions(+), 243 deletions(-)
>
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.h b/drivers/staging/octeon-usb/octeon-hcd.h
> index 42fe4fe..c534e317 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.h
> +++ b/drivers/staging/octeon-usb/octeon-hcd.h
> @@ -143,13 +143,13 @@ union cvmx_usbcx_gahbcfg {
> * * 1'b1: Unmask the interrupt assertion to the application.
> */
> struct cvmx_usbcx_gahbcfg_s {
> - uint32_t reserved_9_31 : 23;
> - uint32_t ptxfemplvl : 1;
> - uint32_t nptxfemplvl : 1;
> - uint32_t reserved_6_6 : 1;
> - uint32_t dmaen : 1;
> - uint32_t hbstlen : 4;
> - uint32_t glblintrmsk : 1;
> + uint32_t reserved_9_31:23;
> + uint32_t ptxfemplvl:1;
> + uint32_t nptxfemplvl:1;
> + uint32_t reserved_6_6:1;
> + uint32_t dmaen:1;
> + uint32_t hbstlen:4;
> + uint32_t glblintrmsk:1;
> } s;

The warning here is:

ERROR: spaces prohibited around that ':' (ctx:WxW)

I have done a kernel wide search for these warnings and I think we
should disable this warning. It has too many false positives like this.

regards,
dan carpenter