From: Tejun Heo <tj@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>,
David Miller <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Li Zefan <lizefan@huawei.com>,
Linux Containers <containers@lists.linux-foundation.org>,
cgroups@vger.kernel.org
Subject: Re: [GIT PULL] cgroup changes for v3.15-rc1
Date: Fri, 4 Apr 2014 08:03:59 -0400 [thread overview]
Message-ID: <20140404120359.GA5461@mtj.dyndns.org> (raw)
In-Reply-To: <CA+55aFw+jFdmmi6eZ6+RpLM9heyowfXsZxb6Y91GNkPU677PmA@mail.gmail.com>
On Thu, Apr 03, 2014 at 01:02:45PM -0700, Linus Torvalds wrote:
> > The cgroup_root should be destroyed but it isn't, I think. We'd need
> > to bump cgroup_root's refcnt only when a new sb is created. It's
> > kinda ugly. Hmmm...
>
> Ok, so I guess we can use that "new_sb_created" thing, and I'll redo
> my merge resolution to reflect that. I do find this incredibly ugly.
I apparently missed the issue and designed the interface without
considering this ugliness. Maybe kernfs could be made to wrap rather
than providing mount/kill_sb() functions and hide details about sb or
we can simply add fstype->umount() so that there's symmetry; however,
the problem is kernfs-specific and other kernfs users would have
single static backing store and won't need to care about this, so, for
now, I think what it's a ugly but acceptable compromise.
Thanks.
--
tejun
next prev parent reply other threads:[~2014-04-04 12:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-03 16:49 [GIT PULL] cgroup changes for v3.15-rc1 Tejun Heo
2014-04-03 18:11 ` Linus Torvalds
2014-04-03 18:24 ` Linus Torvalds
[not found] ` <CAOS58YMckmoCocguf9BC_Wxbn3D2Rx3MArhgozO9qCj4g=5aDw@mail.gmail.com>
2014-04-03 19:01 ` Linus Torvalds
2014-04-03 19:43 ` Tejun Heo
2014-04-03 20:02 ` Linus Torvalds
2014-04-04 12:03 ` Tejun Heo [this message]
2014-04-03 23:18 ` Eric W. Biederman
2014-04-04 9:14 ` Li Zefan
2014-04-04 12:22 ` Tejun Heo
2014-04-05 1:06 ` Linus Torvalds
2014-04-05 1:11 ` Linus Torvalds
2014-04-05 1:34 ` Linus Torvalds
2014-04-07 20:59 ` [PATCH cgroup/for-3.15-fixes] cgroup: newly created dirs and files should be owned by the creator Tejun Heo
2014-04-06 14:31 ` [GIT PULL] cgroup changes for v3.15-rc1 Markus Trippelsdorf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404120359.GA5461@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).