From: Dan Carpenter <dan.carpenter@oracle.com>
To: Kumar Amit Mehta <gmate.amit@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
abbotti@mev.co.uk, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue
Date: Fri, 4 Apr 2014 16:26:51 +0300 [thread overview]
Message-ID: <20140404132651.GV6991@mwanda> (raw)
In-Reply-To: <20140404114852.GA12452@gmail.com>
On Fri, Apr 04, 2014 at 02:48:52PM +0300, Kumar Amit Mehta wrote:
> On Fri, Apr 04, 2014 at 02:07:07PM +0300, Dan Carpenter wrote:
> > On Fri, Apr 04, 2014 at 01:05:29PM +0300, Kumar Amit Mehta wrote:
> > > Fixed a coding style issue. Reported by checkpatch.pl
> > >
> >
> > It's better if the commit messages are more specific than this.
>
> So, should I resend the patch with a more appropriate commit message ?
[PATCH] staging: comedi: drivers: pcl812.c: add curly braces for checkpatch
Kernel style is that if one side of the if else statement gets has curly
braces then both side should have them.
regards,
dan carpenter
next prev parent reply other threads:[~2014-04-04 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 10:05 [PATCH] staging: comedi: drivers: pcl812.c: fixed a coding style issue Kumar Amit Mehta
2014-04-04 11:07 ` Dan Carpenter
2014-04-04 11:48 ` Kumar Amit Mehta
2014-04-04 13:26 ` Dan Carpenter [this message]
2014-04-04 15:17 ` Kumar Amit Mehta
2014-04-04 15:28 ` Joe Perches
2014-04-04 15:32 ` Dan Carpenter
2014-04-04 12:39 ` walter harms
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140404132651.GV6991@mwanda \
--to=dan.carpenter@oracle.com \
--cc=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gmate.amit@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox