From: Andi Kleen <ak@linux.intel.com>
To: Christian Engelmayer <cengelma@gmx.at>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
Michal Marek <mmarek@suse.cz>,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] modpost: Fix ressource leak in read_dump()
Date: Sat, 5 Apr 2014 17:05:12 -0700 [thread overview]
Message-ID: <20140406000512.GS32556@tassilo.jf.intel.com> (raw)
In-Reply-To: <20140406003649.1ba3c993@spike>
On Sun, Apr 06, 2014 at 12:36:49AM +0200, Christian Engelmayer wrote:
> Function read_dump() memory maps the input via grab_file(), but fails to call
> the corresponding unmap function. Add the missing call to release_file().
> Detected by Coverity: CID 1192419
It doesn't matter at all. All memory is freed on exit() in this program.
-Andi
next prev parent reply other threads:[~2014-04-06 0:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-05 22:36 [PATCH] modpost: Fix ressource leak in read_dump() Christian Engelmayer
2014-04-06 0:05 ` Andi Kleen [this message]
2014-04-08 15:10 ` Michal Marek
2014-04-22 7:26 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140406000512.GS32556@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=cengelma@gmx.at \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.cz \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox