* [PATCH] staging: rtl8187se: Fix warning symbol should be static
@ 2014-04-06 15:46 Jonas Hahnfeld
2014-04-06 16:09 ` Josh Triplett
0 siblings, 1 reply; 4+ messages in thread
From: Jonas Hahnfeld @ 2014-04-06 15:46 UTC (permalink / raw)
To: Greg Kroah-Hartman, Ana Rey, Jonas Hahnfeld, Paul Gortmaker,
Pablo Neira Ayuso, Josh Triplett, Rashika Kheria,
Andreea-Cristina Bernat, Andrea Merello, Teodora Baluta,
Dan LaManna, devel, linux-kernel
This patch solves some sparse warnings about "symbol [...] was not
declared. Should it be static?" by including the correct header files.
Signed-off-by: Jonas Hahnfeld <hahnjo@hahnjo.de>
---
Tested by compile only
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c | 1 +
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c | 1 +
drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c | 1 +
drivers/staging/rtl8187se/r8180_wx.c | 1 +
4 files changed, 4 insertions(+)
diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
index 101f0c0..03462c3 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
@@ -19,6 +19,7 @@
#include <linux/string.h>
#include <linux/errno.h>
+#include "../r8180.h"
#include "ieee80211.h"
MODULE_AUTHOR("Jouni Malinen");
diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
index 4fe2538..7eae3d9 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
@@ -21,6 +21,7 @@
#include <linux/string.h>
#include <linux/wireless.h>
+#include "../r8180.h"
#include "ieee80211.h"
#include <linux/crypto.h>
diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
index f253672..288f86c 100644
--- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
+++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
@@ -17,6 +17,7 @@
#include <linux/skbuff.h>
#include <linux/string.h>
+#include "../r8180.h"
#include "ieee80211.h"
#include <linux/crypto.h>
diff --git a/drivers/staging/rtl8187se/r8180_wx.c b/drivers/staging/rtl8187se/r8180_wx.c
index b552491..57bf01f 100644
--- a/drivers/staging/rtl8187se/r8180_wx.c
+++ b/drivers/staging/rtl8187se/r8180_wx.c
@@ -20,6 +20,7 @@
#include "r8180.h"
#include "r8180_hw.h"
+#include "r8180_wx.h"
#include <net/iw_handler.h>
#include "ieee80211/dot11d.h"
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] staging: rtl8187se: Fix warning symbol should be static
2014-04-06 15:46 [PATCH] staging: rtl8187se: Fix warning symbol should be static Jonas Hahnfeld
@ 2014-04-06 16:09 ` Josh Triplett
2014-04-07 1:34 ` Stefan Lippers-Hollmann
0 siblings, 1 reply; 4+ messages in thread
From: Josh Triplett @ 2014-04-06 16:09 UTC (permalink / raw)
To: Jonas Hahnfeld
Cc: Greg Kroah-Hartman, Ana Rey, Paul Gortmaker, Pablo Neira Ayuso,
Rashika Kheria, Andreea-Cristina Bernat, Andrea Merello,
Teodora Baluta, Dan LaManna, devel, linux-kernel
On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> This patch solves some sparse warnings about "symbol [...] was not
> declared. Should it be static?" by including the correct header files.
>
> Signed-off-by: Jonas Hahnfeld <hahnjo@hahnjo.de>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> Tested by compile only
>
> drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c | 1 +
> drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c | 1 +
> drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c | 1 +
> drivers/staging/rtl8187se/r8180_wx.c | 1 +
> 4 files changed, 4 insertions(+)
>
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
> index 101f0c0..03462c3 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt.c
> @@ -19,6 +19,7 @@
> #include <linux/string.h>
> #include <linux/errno.h>
>
> +#include "../r8180.h"
> #include "ieee80211.h"
>
> MODULE_AUTHOR("Jouni Malinen");
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
> index 4fe2538..7eae3d9 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_ccmp.c
> @@ -21,6 +21,7 @@
> #include <linux/string.h>
> #include <linux/wireless.h>
>
> +#include "../r8180.h"
> #include "ieee80211.h"
>
> #include <linux/crypto.h>
> diff --git a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
> index f253672..288f86c 100644
> --- a/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
> +++ b/drivers/staging/rtl8187se/ieee80211/ieee80211_crypt_wep.c
> @@ -17,6 +17,7 @@
> #include <linux/skbuff.h>
> #include <linux/string.h>
>
> +#include "../r8180.h"
> #include "ieee80211.h"
>
> #include <linux/crypto.h>
> diff --git a/drivers/staging/rtl8187se/r8180_wx.c b/drivers/staging/rtl8187se/r8180_wx.c
> index b552491..57bf01f 100644
> --- a/drivers/staging/rtl8187se/r8180_wx.c
> +++ b/drivers/staging/rtl8187se/r8180_wx.c
> @@ -20,6 +20,7 @@
>
> #include "r8180.h"
> #include "r8180_hw.h"
> +#include "r8180_wx.h"
>
> #include <net/iw_handler.h>
> #include "ieee80211/dot11d.h"
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: rtl8187se: Fix warning symbol should be static
2014-04-06 16:09 ` Josh Triplett
@ 2014-04-07 1:34 ` Stefan Lippers-Hollmann
2014-04-07 14:44 ` Jonas Hahnfeld
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Lippers-Hollmann @ 2014-04-07 1:34 UTC (permalink / raw)
To: driverdev-devel
Cc: Josh Triplett, Jonas Hahnfeld, devel, Andreea-Cristina Bernat,
Andrea Merello, Greg Kroah-Hartman, Ana Rey, linux-kernel,
Paul Gortmaker, Rashika Kheria, Teodora Baluta, Dan LaManna,
Pablo Neira Ayuso
Hi
On Sunday 06 April 2014, Josh Triplett wrote:
> On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> > This patch solves some sparse warnings about "symbol [...] was not
> > declared. Should it be static?" by including the correct header files.
> >
> > Signed-off-by: Jonas Hahnfeld <hahnjo@hahnjo.de>
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
[...]
Given that that rtl8187se support has already been merged mainline (for
3.15-rc1) into the existing rtl8180 (soon to be renamed to rtl818x)
driver, wouldn't it make more sense to remove
drivers/staging/rtl8187se/ rather than trying to fixing it?
commit 1eba648f998ef9c31b8cf062754a4a7b4ab9001f
Author: Andrea Merello <andrea.merello@gmail.com>
Date: Wed Mar 26 21:04:23 2014 +0100
rtl8180: enable rtl8187se support
Finally make rtl8187se works (hopefylly).
This patch adds PCI ID for rtl8187, updates copyright notes and
updates MODULE_DESCRIPTION.
Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Regards
Stefan Lippers-Hollmann
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] staging: rtl8187se: Fix warning symbol should be static
2014-04-07 1:34 ` Stefan Lippers-Hollmann
@ 2014-04-07 14:44 ` Jonas Hahnfeld
0 siblings, 0 replies; 4+ messages in thread
From: Jonas Hahnfeld @ 2014-04-07 14:44 UTC (permalink / raw)
To: Stefan Lippers-Hollmann
Cc: driverdev-devel, Josh Triplett, devel, Andreea-Cristina Bernat,
Andrea Merello, Greg Kroah-Hartman, Ana Rey, linux-kernel,
Paul Gortmaker, Rashika Kheria, Teodora Baluta, Dan LaManna,
Pablo Neira Ayuso
Am Montag, den 07.04.2014, 01:34 +0000 schrieb Stefan Lippers-Hollmann:
> Hi
>
> On Sunday 06 April 2014, Josh Triplett wrote:
> > On Sun, Apr 06, 2014 at 05:46:04PM +0200, Jonas Hahnfeld wrote:
> > > This patch solves some sparse warnings about "symbol [...] was not
> > > declared. Should it be static?" by including the correct header files.
> > >
> > > Signed-off-by: Jonas Hahnfeld <hahnjo@hahnjo.de>
> >
> > Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> [...]
>
> Given that that rtl8187se support has already been merged mainline (for
> 3.15-rc1) into the existing rtl8180 (soon to be renamed to rtl818x)
> driver, wouldn't it make more sense to remove
> drivers/staging/rtl8187se/ rather than trying to fixing it?
>
> commit 1eba648f998ef9c31b8cf062754a4a7b4ab9001f
> Author: Andrea Merello <andrea.merello@gmail.com>
> Date: Wed Mar 26 21:04:23 2014 +0100
>
> rtl8180: enable rtl8187se support
>
> Finally make rtl8187se works (hopefylly).
> This patch adds PCI ID for rtl8187, updates copyright notes and
> updates MODULE_DESCRIPTION.
>
> Signed-off-by: Andrea Merello <andrea.merello@gmail.com>
> Signed-off-by: John W. Linville <linville@tuxdriver.com>
>
> Regards
> Stefan Lippers-Hollmann
Yes, probably. Sorry, didn't know that, hadn't looked after this!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-04-07 14:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-06 15:46 [PATCH] staging: rtl8187se: Fix warning symbol should be static Jonas Hahnfeld
2014-04-06 16:09 ` Josh Triplett
2014-04-07 1:34 ` Stefan Lippers-Hollmann
2014-04-07 14:44 ` Jonas Hahnfeld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).